New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 886674 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.5%-33.1% regression in blink_perf.layout at 591938:591956

Project Member Reported by alexclarke@chromium.org, Sep 19

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=886674

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9a1b78e554b3b0326e764dfb4435237d8ab5e1023696895cc5fb864b762a047a


Bot(s) for this bug's original alert(s):

linux-perf

blink_perf.layout - Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Cc: hayato@chromium.org drott@chromium.org yosin@chromium.org wnwen@chromium.org xhw...@chromium.org
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/11def23f640000

Call capture event listeners in capturing phase at shadow hosts by hayato@chromium.org
https://chromium.googlesource.com/chromium/src/+/da8cf24a69567fbc9d2a594489d0ec0566a3d3ad
781.4 → 777.2 (-4.24)

media: Support updated CDM_11 that supports ColorSpace by xhwang@chromium.org
https://chromium.googlesource.com/chromium/src/+/106f5d97d7bb58fcaf47194df98d078506be3aaf
777.2 → 785.5 (+8.36)

Android: Unify android gpu crash counts by wnwen@chromium.org
https://chromium.googlesource.com/chromium/src/+/d52718f19d2052f9a0c6785a091ab178b87eca66
785.9 → 769.5 (-16.43)

Change NGPaintFragment::next_for_same_layout_object_ to raw pointer by yosin@chromium.org
https://chromium.googlesource.com/chromium/src/+/3d757b478829a8fb67d211f932d2a91af5a51ef5
769.9 → 796.5 (+26.58)

Reland: Connect Linux Font Unique Name Lookup to Blink by drott@chromium.org
https://chromium.googlesource.com/chromium/src/+/f973726bdfa204cd47b1ed97070d6b54e113c231
796.4 → 782.3 (-14.11)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
My patch affects only LayoutNG. It should not cause this regression.

Change NGPaintFragment::next_for_same_layout_object_ to raw pointer by yosin@chromium.org
https://chromium.googlesource.com/chromium/src/+/3d757b478829a8fb67d211f932d2a91af5a51ef5
This CL shouldn't be the cause because the change is guarded by the flag.
https://chromium.googlesource.com/chromium/src/+/da8cf24a69567fbc9d2a594489d0ec0566a3d3ad
Owner: ----
Status: Available (was: Assigned)
My change https://chromium.googlesource.com/chromium/src/+/f973726bdfa204cd47b1ed97070d6b54e113c231 is only active in a unit test so far as the font unique name lookup feature is also behind a flag at this point. I don't think it can affect the blink_perf layout code.
Owner: drott@chromium.org
Status: Assigned (was: Available)
📍 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/1092e1df640000

Call capture event listeners in capturing phase at shadow hosts by hayato@chromium.org
https://chromium.googlesource.com/chromium/src/+/da8cf24a69567fbc9d2a594489d0ec0566a3d3ad
804.1 → 799.2 (-4.925)

media: Support updated CDM_11 that supports ColorSpace by xhwang@chromium.org
https://chromium.googlesource.com/chromium/src/+/106f5d97d7bb58fcaf47194df98d078506be3aaf
799.2 → 832.1 (+32.87)

Android: Unify android gpu crash counts by wnwen@chromium.org
https://chromium.googlesource.com/chromium/src/+/d52718f19d2052f9a0c6785a091ab178b87eca66
808.5 → 793.2 (-15.32)

Change NGPaintFragment::next_for_same_layout_object_ to raw pointer by yosin@chromium.org
https://chromium.googlesource.com/chromium/src/+/3d757b478829a8fb67d211f932d2a91af5a51ef5
792.2 → 843.4 (+51.2)

Reland: Connect Linux Font Unique Name Lookup to Blink by drott@chromium.org
https://chromium.googlesource.com/chromium/src/+/f973726bdfa204cd47b1ed97070d6b54e113c231
819.3 → 798.2 (-21.13)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Owner: xhw...@chromium.org
Removing myself as owner and setting to Untriaged - for blink_perf.layout pinpoint seems to find my CL beneficial, not a regression (-21.13, -14.11 respectively). Any ideas, xhwang@?
Owner: ----
Status: Available (was: Assigned)
My change has no way to cause this regression since CDM_11 is no enabled yet.
Cc: -wnwen@chromium.org
GPU crash counts being accounted differently is unrelated to blink perf, removing myself.
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment