New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 886665 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Sep 25
Cc:
yyushkina@chromium.org
pnangunoori@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug


Participants' hotlists:
NTP-Birthday-Polish


Sign in to add a comment

[NTP] 'Done' button does not get disabled on deleting the text from URL field

Reported by sanyam.g...@etouch.net, Sep 19 
Chrome Version: 70.0.3538.22 Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS).

Pre-condition: Enable 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags.

What steps will reproduce the problem?
(1) Launch chrome, open NTP and click on 'Add Shortcut' to open the overlay.
(2) Enter text in URL text-field and then delete the text.
(3) Observe the Done button. 

Actual Result  : 'Done' button does not get disabled on deleting the text from URL field. 
Expected Result: 'Done' button should get disabled on deleting the text from URL field. 

This is a non-regression issue, seen from 'M-70' series as 'Add Shortcut' is introduced from build # 70.0.3504.0

Note: Issue is also seen latest Canary build #71.0.3556.0.

Kindly review the attached screen-cast for review.
Thank You..!!
Actual_Behaviour.mp4
569 KB View Download

Comment 1 by ramyan@chromium.org, Sep 19

Cc: yyushkina@chromium.org
Labels: -Pri-2 -Target-71 ntp-starter-bug Pri-3
Owner: ----
Status: Available (was: Assigned)
Lowering the priority & target since there's still an indication to "Please fill out this field", and a shortcut without a URL cannot be created. Still, it would be nice to  match the behavior that's present when no text has been entered into the URL field.

Comment 2 by sweilun@chromium.org, Sep 25

Owner: sweilun@chromium.org
Status: Started (was: Available)

Comment 3 by twelling...@chromium.org, Sep 25

Labels: zine-triaged
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8b23bab8acece82cced441d32d8c9a8ff646410

commit b8b23bab8acece82cced441d32d8c9a8ff646410
Author: Weilun Shi <sweilun@chromium.org>
Date: Tue Sep 25 20:55:45 2018

[NTP] Disable Done button when textfield is empty

Disable Done button on custom link edit dialog when the url is empty or
spaces only.

Screencast:
https://screencast.googleplex.com/cast/NTk2NTU5NzE1ODQwODE5Mnw3OWZhOGVmNi04Mg

Bug:  886665 
Change-Id: Ic674894e73ff8dc183af740505fdaa906e5241d9
Reviewed-on: https://chromium-review.googlesource.com/1243678
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594092}
[modify] https://crrev.com/b8b23bab8acece82cced441d32d8c9a8ff646410/chrome/browser/resources/local_ntp/custom_links_edit.js

Comment 5 by sweilun@chromium.org, Sep 25

Status: Fixed (was: Started)

Comment 6 by sanyam.g...@etouch.net, Sep 26

Labels: TE-Verified-M71 TE-Verified-71.0.3562.0
Updated:
Re-tested this issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) machines using latest Canary build #71.0.3562.0 and the issue is fixed. Hence adding TE-Verified labels. 

Kindly review an attached screen-cast for reference.

Thank you..!
Fixed_Behaviour.mp4
551 KB View Download
►

Sign in to add a comment