New issue
Advanced search Search tips

Issue 886616 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

some virtual/thread/fast/event layout tests fails

Project Member Reported by xidac...@chromium.org, Sep 19

Issue description

Presently failing tests are:

* virtual/threaded/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
* virtual/threaded/fast/events/touch/gesture/touch-gesture-scroll-div-past-extent.html
* virtual/threaded/fast/events/touch/gesture/touch-gesture-scroll-page-past-extent.html
* virtual/threaded/fast/events/touch/gesture/touch-gesture-scroll-page-zoomed.html
* virtual/threaded/fast/events/touch/gesture/touch-gesture-scroll-page.html
* virtual/threaded/fast/events/touch/touch-action-range-input-csp.html
* virtual/threaded/fast/events/touch/touch-action-range-input.html
Labels: -Pri-3 Sheriff-Chromium Pri-1
Let's revert for now. THere's a lot of failing bots.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04c1d7c1688d4c1d384c6c76aaff54e8e3fb8abc

commit 04c1d7c1688d4c1d384c6c76aaff54e8e3fb8abc
Author: Asanka Herath <asanka@chromium.org>
Date: Wed Sep 19 15:41:18 2018

Revert "Added threaded virtual test suites for fast/events/touch|wheel"

This reverts commit 5fc998cfcd094ea03301605642c8ad30488adb76.

Reason for revert: Added tests are failing. See crbug.com/886616

Original change's description:
> Added threaded virtual test suites for fast/events/touch|wheel
> 
> This cl adds threaded tests suites for fast/events/touch|wheel/* layout tests.
> Other than the following tests the rest of the tests are passing without any
> issues:
> 
> Touchpad fling related tests: these tests are skipped since touchpad swipe
> is recently added to gpu benchmarking. I already have a bug for converting
> these tests to use gpu benchmarking. see crbug.com/857490
> -virtual/threaded/fast/events/touch/gesture/pad-gesture-cancel.html
> -virtual/threaded/fast/events/touch/gesture/pad-gesture-fling.html
> -virtual/threaded/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html
> -virtual/threaded/fast/events/wheel/mainthread-touchpad-fling-latching.html
> -virtual/threaded/fast/events/wheel/wheel-fling-cancel.html
> 
> The following test is flaky, but checking flakiness dashboard showed that its
> other variations are flaky as well. see crbug.com/884312
> -virtual/threaded/fast/events/touch/multi-touch-user-gesture.html
> 
> The following two tests are failing, but again so are their other variations.
> I updated all the expectations to point to the same bug and added expectations
> for the threaded versions. see  crbug.com/876305 
> -virtual/threaded/fast/events/touch/compositor-touch-hit-rects-list-translate.html
> -virtual/threaded/fast/events/touch/compositor-touch-hit-rects.html
> 
> Only the threaded version of the following tests are failing since they are using
> event sender. I filed a bug to convert it to use gpu benchmarking: crbug.com/884332
> -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state-hidden-iframe.html
> -virtual/threaded/fast/events/touch/gesture/gesture-tap-frame-removed.html
> -virtual/threaded/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html
> -virtual/threaded/fast/events/touch/gesture/gesture-tap-active-state.html
> -virtual/threaded/fast/events/touch/gesture/focus-selectionchange-on-tap.html
> 
> One additional test is failing when running with
> --additional-driver-flag=--enable-blink-gen-property-trees, for which I have filed a bug:
>  crbug.com/884846 
> 
> Bug: 874995, 884332, 884312,  876305 
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ifbc4ca54b48307320fe3a703b93cff1620dd1878
> Reviewed-on: https://chromium-review.googlesource.com/1227331
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592215}

TBR=bokan@chromium.org,pdr@chromium.org,sahel@chromium.org

Change-Id: Ida4607d90ff08b8e218491d85165015b05177937
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874995, 884332, 884312,  876305 
Bug: 886616
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1234193
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592412}
[modify] https://crrev.com/04c1d7c1688d4c1d384c6c76aaff54e8e3fb8abc/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/04c1d7c1688d4c1d384c6c76aaff54e8e3fb8abc/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/04c1d7c1688d4c1d384c6c76aaff54e8e3fb8abc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/04c1d7c1688d4c1d384c6c76aaff54e8e3fb8abc/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/57d111143ffdba15eb821f8943005483d10f3117/third_party/WebKit/LayoutTests/virtual/threaded/fast/events/touch/README.txt
[delete] https://crrev.com/57d111143ffdba15eb821f8943005483d10f3117/third_party/WebKit/LayoutTests/virtual/threaded/fast/events/wheel/README.txt

Cc: rhalavati@chromium.org
 Issue 886570  has been merged into this issue.
Labels: -Sheriff-Chromium

Sign in to add a comment