New issue
Advanced search Search tips

Issue 886606 link

Starred by 1 user
Status: Fixed
Owner:
k...@chromium.org
Closed: Sep 20
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Blue focus ring is seen on multiple 'Switch to this tab' button in Omnibox on pressing Shift+tab

Reported by vineetha...@etouch.net, Sep 19 
Chrome Version: 70.0.3538.22 (Official Build) Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}(32/64 bit).
OS: Windows (7, 8, 8.1 ,10), Linux (14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.6, 10.14)

Pre-condition : Enable 'Omnibox tab switch suggestions' under chrome://flags

What steps will reproduce the problem?
1. Launch chrome, open 3 NTPs.
2. Now in each NTP navigate to chrome://version, chrome://flags and chrome://settings respectively.
3. Open a fourth NTP and type 'chrom' in omnibox.
4. Observe that 'Switch to this tab' button is seen for 3 entries in omnibox suggestion list.
5. Press tab to traverse through the omnibox suggestion list to get blue focus on the last 'Switch to this tab' button.
6. Now press Shift+tab to traverse focus backwards and observe the blue focus ring on 'Switch to this tab' button.

Actual Result  : Blue focus ring is seen on multiple 'Switch to this tab' button at the same time.
Expected Result: Blue focus ring should stay on single 'Switch to this tab' button at a time, hence only one button should appear selected.

This is a regression issue broken in ‘M-69’ and below is the per revision bisect info:
Good Build:69.0.3452.0 (Revision:565144)
Bad Build :69.0.3453.0 (Revision:565531)

You are probably looking for a change made after 565153 (known good), but no later than 565154 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/022934873f6e8e16f07e36fabe2bebc1635e91c3..bdf6197e0ac24865a6758b66e294f00c08c48547

Suspect: https://chromium.googlesource.com/chromium/src/+/bdf6197e0ac24865a6758b66e294f00c08c48547

@krb: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1)Issue is also seen on Stable build #69.0.3497.100 , Dev build #71.0.3554.0 and on latest Canary build #71.0.3556.0.
2)In Canary build #71.0.3556.0 the above mentioned flag is enabled by default.

Kindly refer attached screen cast.

Thank you
ActualVideo.mp4
653 KB View Download
ExpectedVideo.mp4
590 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70809a4582d7e955f201e7b0bc49e1065a25e920

commit 70809a4582d7e955f201e7b0bc49e1065a25e920
Author: Kevin Bailey <krb@chromium.org>
Date: Thu Sep 20 16:12:22 2018

[omnibox] Narrow tab switch button IsSelected behavior

Previously OmniboxTabSwitchButton::IsSelected() wasn't asking if
*this* result was selected, only if "the tab switch button" was
focused. This could refer to another result. This change narrows
the implementation of IsSelected() to check if this particular
result is also selected.

Bug:  886606 
Change-Id: I463151848e6cefdbe3afa360d3dbc0e03d2c40ee
Reviewed-on: https://chromium-review.googlesource.com/1234033
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592825}
[modify] https://crrev.com/70809a4582d7e955f201e7b0bc49e1065a25e920/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/70809a4582d7e955f201e7b0bc49e1065a25e920/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/70809a4582d7e955f201e7b0bc49e1065a25e920/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc

Comment 2 by k...@chromium.org, Sep 20

Status: Fixed (was: Assigned)

Comment 3 by vineetha...@etouch.net, Sep 21

Labels: TE-Verified-M71 TE-Verified-71.0.3558.0
Update :
Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)OS with Canary version #71.0.3558.0 and the issue is fixed.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
495 KB View Download
►

Sign in to add a comment