New issue
Advanced search Search tips

Issue 886601 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add more test cases to platform_LowMemoryTest

Project Member Reported by vovoy@chromium.org, Sep 19

Issue description

Adding different page and scenario. E.g. pages with editing content, page with different allocation size.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a7562235745e24610927d75efc22dbae961f6eb0

commit a7562235745e24610927d75efc22dbae961f6eb0
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Thu Sep 20 18:42:05 2018

platform_LowMemoryTest: refactoring to facilitate adding more cases

BUG=chromium:886601
TEST=run platform_LowMemoryTest

Change-Id: Ied173c2434c2e78163898bf70be2f7498775443a
Reviewed-on: https://chromium-review.googlesource.com/1233156
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/a7562235745e24610927d75efc22dbae961f6eb0/client/site_tests/platform_LowMemoryTest/platform_LowMemoryTest.py

Cc: sonnyrao@chromium.org semenzato@chromium.org chinglinyu@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0d014ee125bf6f962305ea5a02af429d3bb9f423

commit 0d014ee125bf6f962305ea5a02af429d3bb9f423
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Mon Oct 01 18:30:57 2018

platform_LowMemoryTest: create more tabs

The OOM killer could be invoked a few seconds after the first tab
discard. Creates a specific amount of tabs instead of ending the test
after the first tab discard.

BUG=chromium:886601
TEST=run platform_LowMemoryTest.form

Change-Id: Id5baf918642092dad783be178d316d784d9f4824
Reviewed-on: https://chromium-review.googlesource.com/1250622
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/0d014ee125bf6f962305ea5a02af429d3bb9f423/client/site_tests/platform_LowMemoryTest/platform_LowMemoryTest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/12813e0a9a5f2ca3f43d906f91ff6f91d5ff0986

commit 12813e0a9a5f2ca3f43d906f91ff6f91d5ff0986
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Fri Oct 05 14:54:56 2018

platform_LowMemoryTest: make random data ratio configurable

All random and uncompressable data is not reasonable, page reclaim would
keep trying to compress swappable pages to zram without freeing memory
to the system, and the swappable pages would drop rapidly and trigger
OOM. Make the ratio of random javascript content configurable to control
the compress ratio, and make 1/3 data compressable by default.

BUG=chromium:886601
TEST=run platform_LowMemoryTest

Change-Id: Ie080b74f7262e3a49554c933f8931e0394b15555
Reviewed-on: https://chromium-review.googlesource.com/1264338
Commit-Ready: Vovo Yang <vovoy@chromium.org>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/12813e0a9a5f2ca3f43d906f91ff6f91d5ff0986/client/site_tests/platform_LowMemoryTest/main.js

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/30b8a645bcfc23201ce46c6304b65b7c687cc917

commit 30b8a645bcfc23201ce46c6304b65b7c687cc917
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Fri Oct 19 02:01:25 2018

platform_LowMemoryTest: add 33_percent_random test case

And rename the original platform_LowMemoryTest to
platform_LowMemoryTest.67_percent_random. 33_percent_random test case
contains 33 percent random data to test the case that most data are
compressable and swap free is exhausted before anonymous is exhausted.

BUG=chromium:886601
TEST=run every platform_LowMemoryTest test cases

Change-Id: I92700f2d31afab496a524473214b8bc911b00c7d
Reviewed-on: https://chromium-review.googlesource.com/1278451
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Vovo Yang <vovoy@chromium.org>

[modify] https://crrev.com/30b8a645bcfc23201ce46c6304b65b7c687cc917/client/site_tests/platform_LowMemoryTest/platform_LowMemoryTest.py
[modify] https://crrev.com/30b8a645bcfc23201ce46c6304b65b7c687cc917/client/site_tests/platform_LowMemoryTest/control.form
[modify] https://crrev.com/30b8a645bcfc23201ce46c6304b65b7c687cc917/client/site_tests/platform_LowMemoryTest/main.js
[copy] https://crrev.com/30b8a645bcfc23201ce46c6304b65b7c687cc917/client/site_tests/platform_LowMemoryTest/control.67_percent_random
[rename] https://crrev.com/30b8a645bcfc23201ce46c6304b65b7c687cc917/client/site_tests/platform_LowMemoryTest/control.33_percent_random

Sign in to add a comment