When a Live Expression yields a DOM node, hovering it should highlight it in the document.
Reported by
nige.ani...@gmail.com,
Sep 19
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.16 Safari/537.36 Steps to reproduce the problem: 1. Create a Live Expression which yields a DOM node 2. Hover the resulting value What is the expected behavior? The referenced node is highlighted in the document. What went wrong? The referenced node is not highlighted in the document. Did this work before? N/A Chrome version: 70.0.3538.16 Channel: beta OS Version: OS X 10.13.6 Flash Version: When it's just div#foo, that doesn't help you work out what and where it is. And as an extra thought, TextNodes should be highlighted when they are displayed anywhere in the debug console and hovered. Right now, they fall outside this scheme.
,
Sep 20
nige.animal@ Thanks for the issue. Request you to provide a sample file where this issue can be reproduced, which will help in further triaging. Thanks..
,
Sep 21
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba904a798c86d5b876fc0ad19ccce834f04d2ce7 commit ba904a798c86d5b876fc0ad19ccce834f04d2ce7 Author: Erik Luo <luoe@chromium.org> Date: Mon Oct 08 21:44:25 2018 DevTools: highlight live expression node previews on hover Hovering nodes that are results of Live expressions will highlight it in the page. Bug: 886596 Change-Id: Ia6d90217a72867cbe831a8bdfc608c983b642317 Reviewed-on: https://chromium-review.googlesource.com/c/1249277 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#597691} [modify] https://crrev.com/ba904a798c86d5b876fc0ad19ccce834f04d2ce7/third_party/blink/renderer/devtools/front_end/console/ConsolePinPane.js [modify] https://crrev.com/ba904a798c86d5b876fc0ad19ccce834f04d2ce7/third_party/blink/renderer/devtools/front_end/object_ui/JavaScriptREPL.js
,
Oct 9
Thanks for the report! I've filed another report for highlighting TextNodes: crbug.com/893426 |
||||
►
Sign in to add a comment |
||||
Comment 1 by susan.boorgula@chromium.org
, Sep 19