New issue
Advanced search Search tips

Issue 886593 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Print destination 'Icon' is seen small in size after changing font size to 'Large' or 'Very Large'

Reported by sanyam.g...@etouch.net, Sep 19 
Chrome Version: 71.0.3556.0 (Official Build) Revision bd6b4db905b5d51ca0ab759729efca79bc0a6046-refs/branch-heads/3556@{#1}(32/64-bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14)

What steps will reproduce the problem?
1. Launch chrome, navigate to 'chrome://settings/' and change font size to 'Large' or 'Very Large'. 
2. Now give print command to open the overlay.
3. Observe the 'Print destination' icon.

Actual Result  : 'Print destination' icon is seen small in size after changing font size to 'Large' or 'Very Large'.
Expected Result: 'Print destination' icon should not be seen small in size after changing font size to 'Large' or 'Very Large'.

This is regression issue broken in ‘M-71’ and below the per-revision bisect info:
Good build: 71.0.3555.0 (Revision: 591861)
Bad build : 71.0.3556.0 (Revision: 592301)

You are probably looking for a change made after 591883 (known good), but no later than 591884 (first known bad).
CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/ed11f063c4d041231aa6622f1f6e521ac2d67384..50bc4aaebd46c013d0fbb8159184babddf0b6e51

Suspect: https://chromium.googlesource.com/chromium/src/+/50bc4aaebd46c013d0fbb8159184babddf0b6e51

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
Actual_Result.mov
4.4 MB View Download
Expected_Result.mov
4.3 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12770d1657f8823f5e867bd3e60e8d2c05065b6

commit a12770d1657f8823f5e867bd3e60e8d2c05065b6
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Sep 21 16:07:04 2018

Print Preview Refresh: Fix destinations polish bugs

Fixing:
(1) Action links fell out of the tab order because destinations_dialog
and destinations_list were not correctly importing action_link.html
(2) Absolute positioning of icon to set it on top of the cr-input in
print_preview_search_box led to icon getting misplaced when browser
window size changed. Fix by adding a prefix in cr-input.
(3) Destination icon was shrinking for large font sizes due to using
flex layout. Make icon fixed size (20px, per spec).
(4) Ensure there is enough margin on the "Manage" link to show the
focus outline.

Bug:  884600 ,  885090 ,  886593 ,  887227 ,  887229 
Change-Id: Ic7d910ad1460e8d457186b9c189797f12db4de5f
Reviewed-on: https://chromium-review.googlesource.com/1237137
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593205}
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/ui/webui/resources/cr_elements/cr_input/cr_input.html

Comment 2 by sanyam.g...@etouch.net, Sep 24

Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Update :
Rechecked the above issue on Mac OS X(10.12.6,10.13.1,10.13.6,10.14) using latest Canary build : 71.0.3559.0 and the issue is Fixed. Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_Behaviour.mov
3.2 MB View Download

Comment 3 by rbpotter@chromium.org, Sep 24

Status: Verified (was: Assigned)
►

Sign in to add a comment