New issue
Advanced search Search tips

Issue 886591 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Page range' text box accepts blank input and focus does not restore back to 'All' radio button when text box is left blank.

Reported by avsha...@etouch.net, Sep 19 
Chrome Version : 71.0.3556.0 (Official Build) bd6b4db905b5d51ca0ab759729efca79bc0a6046-refs/branch-heads/3556@{#1} 32/64 bit
OS : Windows(7, 8, 8.1 ,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

What steps will reproduce the problem?
1. Launch chrome, open NTP and hit 'Ctrl + P' to open print preview.
2. In print preview window, select second (page range) radio button in 'Pages' section.
3. Move mouse and click somewhere in empty space area.
4. Observe the 'page range' text box.

Actual Result : 'Page range' text box accepts blank input and focus does not restore back to 'All' radio button after step 3.

Expected Result : 'Page range' text box should not accepts blank input and focus should restore to 'All' radio button if the 'Page range' text box is left blank.

This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information:
Good Build : 71.0.3551.0 (Revision : 590851)
Bad Build : 71.0.3552.2 (Revision : 591210)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting : https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank you..!
Actual_Result.mp4
820 KB View Download
Expected_Result.mp4
775 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4756a5ebdcd7ced17fe797a74da76725e11f9811

commit 4756a5ebdcd7ced17fe797a74da76725e11f9811
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Sep 22 00:42:38 2018

Print Preview Refresh: Fix some pages bugs

Splitting out fixes for bugs from change to dropdown, in case we decide
not to keep dropdown change. Addresses some focus issues, and removes
use of auto-validate. Auto-validate does not work well for this section
as some errors (e.g. out of range) cannot be caught by the auto
validation. Having 2 different sets of logic for setting the input
invalid (auto-validate + JS validation) causes some bugs.

Bug:  887231 ,  886591 ,  886542 ,  885094 ,  886560 
Change-Id: I053899718a735fa8bcc23df27d36b23d2c26e0b0
Reviewed-on: https://chromium-review.googlesource.com/1238868
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593394}
[modify] https://crrev.com/4756a5ebdcd7ced17fe797a74da76725e11f9811/chrome/browser/resources/print_preview/new/input_behavior.js
[modify] https://crrev.com/4756a5ebdcd7ced17fe797a74da76725e11f9811/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/4756a5ebdcd7ced17fe797a74da76725e11f9811/chrome/browser/resources/print_preview/new/pages_settings.js

Comment 2 by avsha...@etouch.net, Sep 24

Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Update :
---------
Verified above issue in latest Canary build #71.0.3559.0 on Windows(7, 8, 8.1, 10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS and the issue is fixed. 
Now, 'Page range' text box does not accept blank inputs and radio button resets back to 'All' option when page range is left blank, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Canary_behavior.mp4
438 KB View Download

Comment 3 by rbpotter@chromium.org, Sep 24

Status: Verified (was: Assigned)
►

Sign in to add a comment