New issue
Advanced search Search tips
Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 886583: [ios] Adding password generation

Reported by djean@chromium.org, Sep 19 Project Member

Issue description

Attempt at re-adding password generation with updated UX.

Useful references and examples from previous attempt in this bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=700010
 

Comment 1 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7df0a8a06e77c737a586226e91b43a0697f81c4c

commit 7df0a8a06e77c737a586226e91b43a0697f81c4c
Author: David Jean <djean@google.com>
Date: Tue Dec 11 08:25:25 2018

[ios] Add flag for iOS password generation

Bug: 886583
Change-Id: I107a11cdcd9d299533789cffed8c3446561f4968
Reviewed-on: https://chromium-review.googlesource.com/c/1365432
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615464}
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/passwords/credential_manager_egtest.mm
[delete] https://crrev.com/a273f200fdc050016fc34f8dc000d088ae08c1be/ios/chrome/browser/passwords/credential_manager_features.cc
[delete] https://crrev.com/a273f200fdc050016fc34f8dc000d088ae08c1be/ios/chrome/browser/passwords/credential_manager_features.h
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/passwords/password_controller.mm
[add] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/passwords/password_manager_features.cc
[add] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/passwords/password_manager_features.h
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/web/chrome_web_client.mm
[modify] https://crrev.com/7df0a8a06e77c737a586226e91b43a0697f81c4c/ios/chrome/browser/web/chrome_web_client_unittest.mm

Comment 3 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbdd3f69001b1f466d5d4b31eba5f62f30afae45

commit dbdd3f69001b1f466d5d4b31eba5f62f30afae45
Author: David Jean <djean@google.com>
Date: Fri Dec 14 14:41:20 2018

[ios] add suggest password support in password controller

Hidden behind flag.

Bug: 886583

[ios] Add flag for iOS password generation

Bug: 886583
Change-Id: I008609e2eb4da4c1ea547c5ae7114f30846c67b3
Reviewed-on: https://chromium-review.googlesource.com/c/1373816
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616669}
[modify] https://crrev.com/dbdd3f69001b1f466d5d4b31eba5f62f30afae45/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/dbdd3f69001b1f466d5d4b31eba5f62f30afae45/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h
[modify] https://crrev.com/dbdd3f69001b1f466d5d4b31eba5f62f30afae45/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
[modify] https://crrev.com/dbdd3f69001b1f466d5d4b31eba5f62f30afae45/ios/chrome/browser/passwords/password_controller.mm

Comment 4 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c6b24e7f85df534d082c27acbcf71ea1ca038a

commit c0c6b24e7f85df534d082c27acbcf71ea1ca038a
Author: David Jean <djean@google.com>
Date: Tue Dec 18 13:10:18 2018

[ios] Add password generation UI

Also, modified slightly action_sheet_coordinator to allow selecting style of UIAlertController.

Bug: 886583
Change-Id: Icc57b96b8a4033d872d373414a06af0e905b6ca7
Reviewed-on: https://chromium-review.googlesource.com/c/1375950
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617460}
[modify] https://crrev.com/c0c6b24e7f85df534d082c27acbcf71ea1ca038a/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/c0c6b24e7f85df534d082c27acbcf71ea1ca038a/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/c0c6b24e7f85df534d082c27acbcf71ea1ca038a/ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h
[modify] https://crrev.com/c0c6b24e7f85df534d082c27acbcf71ea1ca038a/ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.mm

Comment 5 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a17f4f6f667b74703429f4d2ecc8821c3856959

commit 2a17f4f6f667b74703429f4d2ecc8821c3856959
Author: David Jean <djean@google.com>
Date: Wed Dec 19 13:39:49 2018

[ios] Add password generation manual fallback action

Bug: 886583
Change-Id: I29f7ac59c8fb29888d85031db459296f2ed87eeb
Reviewed-on: https://chromium-review.googlesource.com/c/1378138
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617816}
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/passwords/password_tab_helper.h
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/passwords/password_tab_helper.mm
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_content_delegate.h
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.h
[modify] https://crrev.com/2a17f4f6f667b74703429f4d2ecc8821c3856959/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.mm

Comment 6 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e0c5379d6809b2caf0a08e71834ff589bd7d295

commit 9e0c5379d6809b2caf0a08e71834ff589bd7d295
Author: David Jean <djean@google.com>
Date: Wed Jan 16 12:10:50 2019

[ios] Add js injection for password generation

Bug: 886583

Change-Id: I557d7204102f4a28cfb1f6d91a37df50e117e3bd
Reviewed-on: https://chromium-review.googlesource.com/c/1379898
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623202}
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/autofill/core/common/password_form_generation_data.h
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/core/browser/new_password_form_manager_unittest.cc
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/ios/js_password_manager.h
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/ios/js_password_manager.mm
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/ios/password_form_helper.h
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/ios/password_form_helper.mm
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/components/password_manager/ios/resources/password_controller.js
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/ios/chrome/browser/passwords/password_tab_helper.h
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/ios/chrome/browser/passwords/password_tab_helper.mm
[modify] https://crrev.com/9e0c5379d6809b2caf0a08e71834ff589bd7d295/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm

Comment 7 by bugdroid, Feb 15

Project Member

Comment 8 by bugdroid, Feb 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/283061156bd5bcfd76ef7963c9844b73b154c98e

commit 283061156bd5bcfd76ef7963c9844b73b154c98e
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Fri Feb 15 15:27:43 2019

Introduce PasswordManager interface for password generation on iOS.

The current PasswordManager methods related to generation have a lot of
legacy artifacts that not needed anymore (for example usually
PasswordForm passed in cases when just form identifiers are required).
We need to refactor them some time (namely it would be possible when
the old parser is gone).
It doesn't make sense to use old interface for iOS generation that is
currently in development.

This CL introduces an interface, which will be used from PasswordController.
The implementation will be done in subsequent CLs. The idea to use these
methods on non-iOS platforms in future.

More details in go/bling-password-generation the section
"PasswordManager interface ..."

Bug: 866444, 886583
Change-Id: I9d7dadf6e8ecd34ca440599d772088f99ec70c58
Reviewed-on: https://chromium-review.googlesource.com/c/1474753
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632622}
[modify] https://crrev.com/283061156bd5bcfd76ef7963c9844b73b154c98e/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/283061156bd5bcfd76ef7963c9844b73b154c98e/components/password_manager/core/browser/password_manager.h

Comment 9 by bugdroid, Feb 18 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9121268dd5e48aa51d06c512fb41f2ed8509a777

commit 9121268dd5e48aa51d06c512fb41f2ed8509a777
Author: David Jean <djean@google.com>
Date: Mon Feb 18 09:44:05 2019

[ios] Password generation todos

Addressed some password generation TODO, mainly for i18n strings and validation of fields.

Bug: 886583
Change-Id: I5069679607504e7c80d3d41f17f971918fe2ed89
Reviewed-on: https://chromium-review.googlesource.com/c/1429980
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633056}
[modify] https://crrev.com/9121268dd5e48aa51d06c512fb41f2ed8509a777/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/9121268dd5e48aa51d06c512fb41f2ed8509a777/ios/chrome/browser/passwords/password_controller.mm

Comment 10 by bugdroid, Feb 21 (2 days ago)

Project Member

Sign in to add a comment