New issue
Advanced search Search tips

Issue 886551 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Print preview] Grey focus highlight on checkbox appears chopped.

Reported by rp...@etouch.net, Sep 19

Issue description

Chrome Version: 71.0.3556.0 (Official Build)Revision bd6b4db905b5d51ca0ab759729efca79bc0a6046-refs/branch-heads/3556@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview
2. Click to expand 'More settings' 
3. Now press 'Tab' key to move focus on headers and footers Checkbox , observe

Actual Result: Grey focus highlight on checkbox appears chopped
Expected Result: Grey focus highlight should be seen properly

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3555.0 (Revision: 591861)
Bad build : 71.0.3556.0 (Revision: 592301)
 
Actual_screenshot.png
103 KB View Download
Expected_screenshot.png
111 KB View Download
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591883 (known good), but no later than 591884 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/ed11f063c4d041231aa6622f1f6e521ac2d67384..50bc4aaebd46c013d0fbb8159184babddf0b6e51

Suspecting: https://chromium.googlesource.com/chromium/src/+/50bc4aaebd46c013d0fbb8159184babddf0b6e51

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63451843bf9fb084a878417e4d118caa72a2f003

commit 63451843bf9fb084a878417e4d118caa72a2f003
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 22:54:45 2018

Print Preview refresh: Fix radio and checkbox ripple sizing issues

Default ripple size of 40px is 2px larger than the desired height for
a print preview settings section/row of settings section. Reduce
ripple size to match this limitation.

For copies' collate box, remove unnecessary margin that caused the
number input to shift when the checkbox appeared. Also reduce the
default size for number inputs, since neither should exceed 3 digits,
and ensure the inline margin is always large enough for the ripple
regardless of font size.

Bug:  885013 ,  885026 ,  886551 
Change-Id: I29b8316b9f49e24ffcb020085ef9bc3cdb6e0ec9
Reviewed-on: https://chromium-review.googlesource.com/1235204
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592985}
[modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/print_preview_shared_css.html

Labels: TE-Verified-M71 TE-Verified-71.0.3558.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14) using latest Canary build : 71.0.3558.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mp4
489 KB View Download
Status: Verified (was: Assigned)

Sign in to add a comment