Regression: 'Welcome to Chrome' text is seen on print preview overlay, even when it is not there on chrome://welcome page.
Reported by
aiman.an...@etouch.net,
Sep 19
|
|||||
Issue descriptionChrome Version: 70.0.3538.22 (Official Build) Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468} (32/64 bit). OS: Windows (7, 8, 8.1 ,10), Linux (14.04 LTS), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://welcome. 2. Click on page and hit CMD+A to select all contents of the page. 3. Now, give print command and in print preview check 'Selection only' option under 'More Settings'. 4. Observe print preview page. Actual Result: 'Welcome to Chrome' text is seen on print preview, even when it is not there on chrome://welcome page. Expected Result: Contents present on the page should be seen on Print preview. This is a regression issue broken in ‘M-70’ and below is the per revision bisect info: Good Build:70.0.3525.0 (Revision:583912) Bad Build:70.0.3526.0 (Revision:584272) You are probably looking for a change made after 583987 (known good), but no later than 583988 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f7f385986a69d648d77b0b9f7821e7901df5c90f..00d099ea75e9565afdee5be3f8e4f54eabc7ae0b Suspect: https://chromium.googlesource.com/chromium/src/+/00d099ea75e9565afdee5be3f8e4f54eabc7ae0b droger@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Issue is also seen on Dev build #71.0.3554.0 and on latest Canary build #71.0.3555.0. Kindly refer the screen-cast for reference from the given link. https://drive.google.com/drive/folders/1q78hC9nI-h830DJDpO6aAJG7w1SQsFt4?usp=sharing Thank you...
,
Sep 19
rbpotter@ how do we deal with "print selection only" when some visibility:none texts are selected?
,
Oct 5
Print Preview doesn't actually make any decisions about how to render text for printing based on CSS. I think that's in Blink, so tagging with blink label and un-assigning. Comment 1 is correct that this is very low priority (printing chrome://pages with specific parameters).
,
Oct 5
I can reproduce the issue. Setting component to Blink>Editing>Selection for further triage.
,
Oct 11
Mark WontFix since this is work as expected.
The page has a text "Welcome to Chrome" and it is height:0 and opacity:0.
It seems Print Preview takes from following HTML in shadow DOM tree of <welcome-app>.
<div class="heading-container">
<div class="heading">Welcome to Chrome</div>
<div class="second-heading">Web browsing with Google smarts</div>
</div>
.heading {
animation: fadeOutAndSlideUp 600ms 2.1s cubic-bezier(.4, .2, 0, 1) forwards;
/* Makes sure fading-in/out doesn't impact the logo position. */
position: absolute;
}
@keyframes fadeOutAndSlideUp {
to {
height: 0;
opacity: 0;
transform: translateY(-8px);
}
}
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by droger@chromium.org
, Sep 19Owner: scottchen@chromium.org