New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 886531 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in _platform_memmove$VARIANT$Nehalem

Project Member Reported by ClusterFuzz, Sep 19

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5700602460635136

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: UNKNOWN WRITE
Crash Address: 0x0001390dd000
Crash State:
  _platform_memmove$VARIANT$Nehalem
  SkBinaryWriteBuffer::writeByteArray
  SkTextBlobPriv::Flatten
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=585071:585171

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5700602460635136

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 19

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 19

Labels: Target-70 M-70
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 19

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 19

Labels: Pri-1
Cc: herb@chromium.org brianosman@chromium.org mtklein@chromium.org
+ some Skia folks - can you follow this up?
Can anyone human out there reproduce this?

I've got this GN'd, built, ASAN_OPTIONS exported, and running just like the bot, but it doesn't seem to be crashing.  It's just hung on a dialog box, and if I click through it, I see a zillion lines of the same text.

From the stack, a failure here looks like a failure to malloc/realloc.  Not really sure what to do about that...  and I thought Skia was hooked up so that those failures are immediately fatal in Chromium?

Is there any way to know how long the bot took before it crashed?  It looks like maybe there's a slow memory leak, but it's Chromium so who knows, and at this rate I think I'd need to leave it running for a couple days to get to 64GB.  Even then, I wouldn't expect the OOM to hit the exact same spot in SkWriter32.

Attached images of before/after clicking through the dialog.
Screen Shot 2018-09-25 at 3.57.17 PM.png
563 KB View Download
Screen Shot 2018-09-25 at 3.57.50 PM.png
1.0 MB View Download
Cc: ellyjo...@chromium.org sdy@chromium.org
The actual crash seems to be in a library call of some sort, so it's possible this is an issue just with this particular bot configuration.

+ some Mac folks for thoughts, but if we can't properly repro we can WontFix.
Cc: r...@chromium.org
+rnk@: Possibly related to issue 797267?
Oh, hmm. Maybe not related. rnk@, feel free to jump in or un-cc yourself.
[bulk edit] - This issue is marked as a stable blocker for M70. We are two weeks away from M70 Stable. Please take a look urgently!
Owner: r...@chromium.org
rnk: Assigning to you so that the bug has an owner. Could you please take a look and reassign as appropriate? Thanks.
Status: Assigned (was: Untriaged)
Cc: -r...@chromium.org
Owner: ----
Unassigning, not our bug. issue 797267 was unrelated.
Labels: -ReleaseBlock-Stable ReleaseBlock-NA
Has anyone from Skia been able to repro this? If not, I vote for closing this.
Project Member

Comment 16 by ClusterFuzz, Oct 9

Labels: -Reproducible Unreproducible
ClusterFuzz testcase 5700602460635136 appears to be flaky, updating reproducibility label.
Status: WontFix (was: Assigned)
Cc: reed@chromium.org
Just noticed that this is similar to bug 882876. 
Project Member

Comment 19 by sheriffbot@chromium.org, Jan 15

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment