New issue
Advanced search Search tips

Issue 886528 link

Starred by 2 users
Status: Fixed
Owner:
oysteine@chromium.org
Closed: Sep 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Multiple tests in "TracingControllerTest.*" are flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 19 
"TracingControllerTest.EnableAndStopTracingWithFilePath" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 9 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQQsSBUZsYWtlIjZUcmFjaW5nQ29udHJvbGxlclRlc3QuRW5hYmxlQW5kU3RvcFRyYWNpbmdXaXRoRmlsZVBhdGgM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 862414 .

Comment 1 by asanka@chromium.org, Sep 19

Summary: Multiple tests in "TracingControllerTest.*" are flaky (was: "TracingControllerTest.EnableAndStopTracingWithFilePath" is flaky)
Moving c0's from the other bugs that were auto filed:

"TracingControllerTest.EnableAndStopTracing" is flaky.


We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipUcmFjaW5nQ29udHJvbGxlclRlc3QuRW5hYmxlQW5kU3RvcFRyYWNpbmcM.

"TracingControllerTest.DisableRecordingStoresMetadata" is flaky.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPwsSBUZsYWtlIjRUcmFjaW5nQ29udHJvbGxlclRlc3QuRGlzYWJsZVJlY29yZGluZ1N0b3Jlc01ldGFkYXRhDA.


Flaky test: TracingControllerTest.EnableAndStopTracingWithCompression
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=40070b7a74ce5510
Test output log: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/103944
Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Id2681970db5b7ea5cadf0ee9bbcbbc1ebbba08c3
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKRAWNocm9taXVtLm1lbW9yeS9MaW51eCBUU2FuIFRlc3RzLzI2MDIyL3BlcmZldHRvX2NvbnRlbnRfYnJvd3NlcnRlc3RzL1ZISmhZMmx1WjBOdmJuUnliMnhzWlhKVVpYTjBMa1Z1WVdKc1pVRnVaRk4wYjNCVWNtRmphVzVuVjJsMGFFTnZiWEJ5WlhOemFXOXUMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20TracingControllerTest.EnableAndStopTracingWithCompression&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKRAWNocm9taXVtLm1lbW9yeS9MaW51eCBUU2FuIFRlc3RzLzI2MDIyL3BlcmZldHRvX2NvbnRlbnRfYnJvd3NlcnRlc3RzL1ZISmhZMmx1WjBOdmJuUnliMnhzWlhKVVpYTjBMa1Z1WVdKc1pVRnVaRk4wYjNCVWNtRmphVzVuVjJsMGFFTnZiWEJ5WlhOemFXOXUMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Comment 2 by asanka@chromium.org, Sep 19 

 Issue 886527  has been merged into this issue.

Comment 3 by asanka@chromium.org, Sep 19 

 Issue 886526  has been merged into this issue.

Comment 4 by asanka@chromium.org, Sep 19 

 Issue 885389  has been merged into this issue.

Comment 5 by asanka@chromium.org, Sep 19

Owner: oysteine@chromium.org
Status: Assigned (was: Untriaged)
Assigning to oysteine@ for https://chromium-review.googlesource.com/c/chromium/src/+/1232414

Comment 6 by asanka@chromium.org, Sep 19

Components: Speed>Tracing
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d4c320181d981b3dea0e4decead0e740bbb056f

commit 0d4c320181d981b3dea0e4decead0e740bbb056f
Author: Oystein Eftevaag <oysteine@google.com>
Date: Wed Sep 19 19:06:29 2018

Perfetto: Finalize messages before destroying trace writer

This fixes a data race where ~TraceWriter tries finalizing the
same message as ~TraceEventDataSource, on a different sequence
(TraceWriter is owned by TraceEventDataSource, but needs to
be destructed on a different sequence due to ~TraceEventDataSource
being called on thread shutdown and could be calling PostTask).

BUG= 886528 
R=ssid@chromium.org

Change-Id: I61b498b8b4bcf3b40e43e9db49711e593766df26
Reviewed-on: https://chromium-review.googlesource.com/1232414
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592500}
[modify] https://crrev.com/0d4c320181d981b3dea0e4decead0e740bbb056f/services/tracing/public/cpp/perfetto/trace_event_data_source.cc

Comment 8 by asanka@chromium.org, Sep 19

Labels: -Sheriff-Chromium
Thanks!

Comment 9 by oysteine@chromium.org, Sep 19

Status: Fixed (was: Assigned)
Looks fixed on the bots; closing.
►

Sign in to add a comment