New issue
Advanced search Search tips

Issue 886390 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Sep 24
Cc:
omrilio@chromium.org
x...@chromium.org
mccanny@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Minimized windows aren't animating back after unsuccessful close

Project Member Reported by mccanny@chromium.org, Sep 19 
Chrome OS Version: 71.0.3552.6

What steps will reproduce the problem?
(1) Minimize a window
(2) Open overview
(3) Drag a window up or down a bit, but not enough to trigger closing the window
(4) Release

What is the expected result?

Window animates back the same as unminimized window


What happens instead?

Minimized windows snap back immediately. See contrast between minimized and unminimized windows in screencap: https://drive.google.com/open?id=118KOAFiwgMtLcwgmv6DTL9nUtD1pRdri
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a89fd4a1e4e7d50435b07fdb119a8f885e9916

commit 83a89fd4a1e4e7d50435b07fdb119a8f885e9916
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Sep 24 17:47:43 2018

overview: Fix issues with minimized windows in overview.

The minimized windows are now stacked underneath non-minimized windows.
Minimized windows now animate back when uncessfully swipe to close.

Test: manual
Bug:  886392 ,  886390 
Change-Id: I520a9cfc642e5f417af6755b783b831098430ce8
Reviewed-on: https://chromium-review.googlesource.com/1238782
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593590}
[modify] https://crrev.com/83a89fd4a1e4e7d50435b07fdb119a8f885e9916/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/83a89fd4a1e4e7d50435b07fdb119a8f885e9916/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/83a89fd4a1e4e7d50435b07fdb119a8f885e9916/ash/wm/overview/window_selector_unittest.cc

Comment 2 by sammiequon@chromium.org, Sep 24

Labels: OS-Chrome
Status: Fixed (was: Untriaged)
►

Sign in to add a comment