Horrid flickering when closing the launcher from FULLSCREEN_SEARCH |
|||||||||||
Issue descriptionChrome Version: 71.0.3556.0 OS: ChromeOS What steps will reproduce the problem? (1) Open Launcher to FULLSCREEN_ALL_APPS (all the way open) (2) Tap the search box to activate (engaging FULLSCREEN_SEARCH (3) Swipe the launcher closed. What is the expected result? Smooth Transition What happens instead? Flickers back open immediately before closing. This is a regression, bisect has not been performed, yet. Video: https://photos.app.goo.gl/64ovSZCyHkPAJac56
,
Sep 19
,
Sep 19
Unsure if this ended up in M-70
,
Sep 19
Is at least 1 week old
,
Sep 19
Although I am equally upset at a bug of this nature, P-0 is usually reserved for large outages that functionally impact the usage of CrOS. Downgrading to P-1.
,
Sep 20
,
Sep 20
CL is open and being reviewed by Yury to ensure that it doesn't break what was originally fixed by the breaking CL
,
Sep 20
this is the breaking CL mentioned: https://chromium-review.googlesource.com/c/chromium/src/+/1197328 newcomer@, can you quickly verify that that CL wasn't merged back into M70, or earlier?
,
Sep 20
,
Sep 21
In that case whichever CL makes it as the final Fix here should also get merged into M70
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b19b7fdb430e82380185b8ba5d9a164f671b871 commit 3b19b7fdb430e82380185b8ba5d9a164f671b871 Author: Kevin Strohbehn <ginko@google.com> Date: Fri Sep 21 00:53:08 2018 Prevents horrid flicker from occuring during app list close Drag closed from FULLSCREEN_SEARCH Drag closed from HALF_SEARCH Drag closed from PEEKING Drag closed from FULLSCREEN_ALL_APPS Bug: 885909 Change-Id: Ia13a5da2fefa408bc440d663f83763c93a80fc80 Test: Manually tested scenarios: Reviewed-on: https://chromium-review.googlesource.com/1237395 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593031} [modify] https://crrev.com/3b19b7fdb430e82380185b8ba5d9a164f671b871/ash/app_list/views/app_list_view.cc
,
Sep 21
,
Sep 22
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 24
,
Sep 24
,
Sep 28
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e5ad76a2022f431a126562cdc182dce71ee0a6 Commit: 68e5ad76a2022f431a126562cdc182dce71ee0a6 Author: ginko@google.com Commiter: newcomer@chromium.org Date: 2018-09-28 19:32:51 +0000 UTC Prevents horrid flicker from occuring during app list close Drag closed from FULLSCREEN_SEARCH Drag closed from HALF_SEARCH Drag closed from PEEKING Drag closed from FULLSCREEN_ALL_APPS Bug: 885909 Change-Id: Ia13a5da2fefa408bc440d663f83763c93a80fc80 Test: Manually tested scenarios: Reviewed-on: https://chromium-review.googlesource.com/1237395 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593031}(cherry picked from commit 3b19b7fdb430e82380185b8ba5d9a164f671b871) Reviewed-on: https://chromium-review.googlesource.com/1252601 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#744} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68e5ad76a2022f431a126562cdc182dce71ee0a6 commit 68e5ad76a2022f431a126562cdc182dce71ee0a6 Author: Kevin Strohbehn <ginko@google.com> Date: Fri Sep 28 19:32:51 2018 Prevents horrid flicker from occuring during app list close Drag closed from FULLSCREEN_SEARCH Drag closed from HALF_SEARCH Drag closed from PEEKING Drag closed from FULLSCREEN_ALL_APPS Bug: 885909 Change-Id: Ia13a5da2fefa408bc440d663f83763c93a80fc80 Test: Manually tested scenarios: Reviewed-on: https://chromium-review.googlesource.com/1237395 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593031}(cherry picked from commit 3b19b7fdb430e82380185b8ba5d9a164f671b871) Reviewed-on: https://chromium-review.googlesource.com/1252601 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#744} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/68e5ad76a2022f431a126562cdc182dce71ee0a6/ash/app_list/views/app_list_view.cc |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ginko@chromium.org
, Sep 19