Files app: Folder name is not updated in breadcrumb trail after rename operation |
||||||||||
Issue descriptionChromeOS 11021.19.0, 70.0.3538.22 dev-channel eve What steps will reproduce the problem? 1. Open Files app downloads folder 2. Create 2 folders one within the other (say FolderA and FolderB) 3. Click on 'FolderB' in the side-nav 4. Right-click on 'FolderA' and rename it to 'FolderABC' 5. Now click on 'FolderB' in the side-nav 6. Observe the breadcrumb trail What is the expected result? Breadcrumb trail is updated with the new folder name My files > Downloads > FolderABC > FolderB What happens instead? Breadcrumb trail is not updated with new folder name My files > Downloads > FolderA > FolderB Nothing happens on clicking 'FolderA' from the breadcrumb trail.
,
Sep 18
,
Sep 19
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d857eab60409f1cb253736bce3b23691ea5f026 commit 5d857eab60409f1cb253736bce3b23691ea5f026 Author: Luciano Pacheco <lucmult@chromium.org> Date: Wed Sep 19 09:39:06 2018 Fix breadcrumb when renaming parent. When a folder is renamed all its children entries in the DirectoryTree gets stale, because their |fullPath| property are outdated. Change DirectoryTreeNamingController to force update the renamed folder's children, so they have the new |fullPath|. This fix the linked bug because when navigating to children folder the breadcrumbs is generated based on |fullPath|. Bug: 885328 Change-Id: I02c39d5289454243d2996d765d5631e17e08b31e Reviewed-on: https://chromium-review.googlesource.com/1233274 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#592355} [modify] https://crrev.com/5d857eab60409f1cb253736bce3b23691ea5f026/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/5d857eab60409f1cb253736bce3b23691ea5f026/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js [modify] https://crrev.com/5d857eab60409f1cb253736bce3b23691ea5f026/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
,
Sep 24
Fixed? Shall we ask for a merge into 70?
,
Sep 25
Request to merge crrev.com/c/1233274. Tested manually on local branch from branch-heads/3538 also run Files app integration tests, all of them worked.
,
Sep 25
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25
,
Sep 26
Issue 889308 has been merged into this issue.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4163aa91b011eaa74a85d0ba6a5a15139de9eebc Commit: 4163aa91b011eaa74a85d0ba6a5a15139de9eebc Author: lucmult@chromium.org Commiter: lucmult@chromium.org Date: 2018-09-27 00:37:01 +0000 UTC Fix breadcrumb when renaming parent. When a folder is renamed all its children entries in the DirectoryTree gets stale, because their |fullPath| property are outdated. Change DirectoryTreeNamingController to force update the renamed folder's children, so they have the new |fullPath|. This fix the linked bug because when navigating to children folder the breadcrumbs is generated based on |fullPath|. Bug: 885328 Change-Id: I02c39d5289454243d2996d765d5631e17e08b31e Reviewed-on: https://chromium-review.googlesource.com/1233274 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592355}(cherry picked from commit 5d857eab60409f1cb253736bce3b23691ea5f026) Reviewed-on: https://chromium-review.googlesource.com/1247601 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#692} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4163aa91b011eaa74a85d0ba6a5a15139de9eebc commit 4163aa91b011eaa74a85d0ba6a5a15139de9eebc Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Sep 27 00:37:01 2018 Fix breadcrumb when renaming parent. When a folder is renamed all its children entries in the DirectoryTree gets stale, because their |fullPath| property are outdated. Change DirectoryTreeNamingController to force update the renamed folder's children, so they have the new |fullPath|. This fix the linked bug because when navigating to children folder the breadcrumbs is generated based on |fullPath|. Bug: 885328 Change-Id: I02c39d5289454243d2996d765d5631e17e08b31e Reviewed-on: https://chromium-review.googlesource.com/1233274 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592355}(cherry picked from commit 5d857eab60409f1cb253736bce3b23691ea5f026) Reviewed-on: https://chromium-review.googlesource.com/1247601 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#692} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/4163aa91b011eaa74a85d0ba6a5a15139de9eebc/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/4163aa91b011eaa74a85d0ba6a5a15139de9eebc/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js [modify] https://crrev.com/4163aa91b011eaa74a85d0ba6a5a15139de9eebc/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
,
Sep 27
Fixed on ToT (m71) and on m70.
,
Oct 11
Verified on ChromeOS 11021.45.0, 70.0.3538.58 beta-channel eve |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sdantul...@chromium.org
, Sep 18