New issue
Advanced search Search tips

Issue 885326 link

Starred by 1 user
Status: Verified
Owner:
katie@chromium.org
Closed: Sep 27
Cc:
tetsui@chromium.org
katie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

STS not updating clock time until restarted

Project Member Reported by leberly@chromium.org, Sep 18 
Google Chrome	70.0.3538.16 (Official Build) dev (64-bit)
Firmware Version Google_Caroline.7820.384.0

Steps to reproduce:
# Enable STS from the Accessibility Settings, taking note of what time you enable it
# Invoke STS using search + mouse on the time in the lower right corner 
# Wait at least one minute for the time to change
# Invoke STS on the time again
Expected: time is updated
Actual: still reads the time from when the feature was turned on

Please see this video for a demo of the time being read incorrectly: https://drive.google.com/file/d/19JzqQ42AE92mESwO0TmVmx0aI1UDls52/view

Comment 1 by katie@chromium.org, Sep 26

Cc: tetsui@chromium.org
Reproduced in M71.
https://cs.chromium.org/chromium/src/ash/system/date/ may be related

Looks like the TrayTimeView may have the correct content description, but there is a static text within the time that has the wrong content description.

In the accessibility tree, it appears like this:
> role: time, name: "407 PM, Wednesday, September 26 2018"
  > role: staticText, name: "4:02"

The inner child staticText should be 4:07 at this point.

+tetsui@ who may have more insight.

Comment 2 by katie@chromium.org, Sep 26 

I think this is probably related to  crbug.com/876419  where changing a label's text does not update it's accessibility info.

I tried fixing this in the other bug by just having all Label.setText() call notifyAccessibilityEvent, but as discussed in code review this wasn't the best solution: https://chromium-review.googlesource.com/c/chromium/src/+/1185738/1/ui/views/controls/label.cc#88

Comment 3 by katie@chromium.org, Sep 26

Owner: katie@chromium.org
Status: Started (was: Available)

Comment 4 by katie@chromium.org, Sep 27 

Looks like this affects some other views as well in both the new and the old system tray, including battery percentage and time remaining.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8618df060a75cd3b4b76f6bb6770b94be60228bf

commit 8618df060a75cd3b4b76f6bb6770b94be60228bf
Author: Katie D <katie@chromium.org>
Date: Thu Sep 27 06:26:29 2018

Labels must be updated for accessibility after text changes.

Bug:  885326 
Change-Id: I19764f67b871577d2b8e206800526508bc784fd8
Reviewed-on: https://chromium-review.googlesource.com/1245118
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594610}
[modify] https://crrev.com/8618df060a75cd3b4b76f6bb6770b94be60228bf/ash/system/date/date_view.cc
[modify] https://crrev.com/8618df060a75cd3b4b76f6bb6770b94be60228bf/ash/system/unified/unified_system_info_view.cc

Comment 6 by katie@chromium.org, Sep 27

Labels: a11y-testers
Status: Fixed (was: Started)

Comment 7 by leberly@chromium.org, Oct 8

Status: Verified (was: Fixed)
Google Chrome	71.0.3567.0 (Official Build) dev (64-bit)
Firmware Version Google_Caroline.7820.384.0

I verified that this works by using STS in the system tray, checking that the current time is read, waiting until the time changes, and using STS again. STS reads the current time.

Comment 8 by leberly@chromium.org, Oct 8

Labels: -a11y-testers
►

Sign in to add a comment