Menu items like "Open When Done", "Always Open Files for this type", "Show in Finder" don't make sense for background fetch. So we should remove them for OfflineItem. UX : https://docs.google.com/presentation/d/169w6B-ejNZK-w-_P2nbblD0B-TSnPat0fVz0y8WZnwk/edit?ts=5b980844#slide=id.g25fd76dd9d_0_67
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab33e9ff83b69e77c182635169dcedc2ecfead54 commit ab33e9ff83b69e77c182635169dcedc2ecfead54 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Sep 20 02:43:38 2018 Download Shelf : Changed DownloadShelfContextMenu to work with DownloadUIModel Bug: 885322 Change-Id: Id509eb2009958b2532a428abd8db5156a7c026ae Reviewed-on: https://chromium-review.googlesource.com/1232477 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592667} [modify] https://crrev.com/ab33e9ff83b69e77c182635169dcedc2ecfead54/chrome/browser/download/download_shelf_context_menu.cc [modify] https://crrev.com/ab33e9ff83b69e77c182635169dcedc2ecfead54/chrome/browser/download/download_shelf_context_menu.h [modify] https://crrev.com/ab33e9ff83b69e77c182635169dcedc2ecfead54/chrome/browser/ui/views/download/download_shelf_context_menu_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41 commit 31f9fa1f0ebac2c503a5774314f4e2231a6b7d41 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Sep 21 20:53:58 2018 Download Shelf : Changed DownloadCommands to work on DownloadUIModel Bug: 885322 Change-Id: Ie8b8c31ca6b8aa1a365c69b30d045b9a6eb02ee8 Reviewed-on: https://chromium-review.googlesource.com/1233115 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593328} [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_commands.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_commands.h [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_commands_unittest.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_item_model.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_item_model.h [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_shelf_context_menu.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_shelf_context_menu.h [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_ui_model.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/download_ui_model.h [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/notification/download_item_notification.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/offline_item_model.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/download/offline_item_model.h [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/safe_browsing/download_protection/download_feedback_service.cc [modify] https://crrev.com/31f9fa1f0ebac2c503a5774314f4e2231a6b7d41/chrome/browser/ui/views/download/download_item_view.cc
Comment 1 by bugdroid1@chromium.org
, Sep 20