New issue
Advanced search Search tips

Issue 885321 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use NotFoundError instead of InvalidPointerId in pointerevents exception

Project Member Reported by nzolghadr@chromium.org, Sep 18

Issue description

Since the spec changed around that we need to follow the same in Chrome:
https://github.com/w3c/pointerevents/issues/256

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80978f70228a6951a92649851f29634ed630d870

commit 80978f70228a6951a92649851f29634ed630d870
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Thu Sep 20 19:36:07 2018

Use NotFoundError instead of InvalidPointerId

This cl follows the new pointerevent spec which
uses more common WebIDL specified exception
NotFoundError instead of defining new
InvalidPointerId exception.

Bug:  885321 
Change-Id: I28e946ffcb96c9fb4f70c76a4b9c09be620f981d
Reviewed-on: https://chromium-review.googlesource.com/1231990
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592903}
[modify] https://crrev.com/80978f70228a6951a92649851f29634ed630d870/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-manual.html
[modify] https://crrev.com/80978f70228a6951a92649851f29634ed630d870/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_setpointercapture_invalid_pointerid-manual.html
[modify] https://crrev.com/80978f70228a6951a92649851f29634ed630d870/third_party/blink/renderer/core/dom/dom_exception.cc
[modify] https://crrev.com/80978f70228a6951a92649851f29634ed630d870/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/80978f70228a6951a92649851f29634ed630d870/third_party/blink/renderer/platform/bindings/exception_code.h

Status: Fixed (was: Started)

Sign in to add a comment