New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 885313 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Sign in to add a comment

Web Share Target "V2" for WebAPKs master bug

Project Member Reported by hartma...@chromium.org, Sep 18

Issue description

We're looking to implement POST functionality as well as support for the method, enctype, and files members of the draft spec:

https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#launching-the-web-share-target
 
Server-side bug: http://b/114764977
Blockedon: 885314
Cc: mgiuca@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a336dd09327ff666da1042309c4b07ab7849c85a

commit a336dd09327ff666da1042309c4b07ab7849c85a
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Thu Nov 01 18:58:33 2018

[Android WebAPK Refactor] Send activity name in intent only for share targets 8/X

This CL changes the WebAPK to send the name of the launching activity only for
share targets. The goal of this CL are:
- In an upcoming CL I will send an intent to Chrome to relaunch the WebAPK. This CL removes the need
  to send the action which launched the WebAPK to Chrome. (ACTION_SEND can be assumed if the
  org.chromium.webapk.selected_share_target_activity_class_name extra is set.)
- Add a layer of defense in depth for POST share targets. An incoming intent is for a POST share
  target if:
  1) org.chromium.webapk.selected_share_target_activity_class_name is set on the intent
  2) The <meta-data> for the passed in activity has a org.chromium.webapk.shell_apk.shareEnctype
     key.

BUG=817263, 885313

Change-Id: I3667d257f711f1e474a44e3fd9aaf5c41552f30c
Reviewed-on: https://chromium-review.googlesource.com/c/1307075
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604656}
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/shell_apk/current_version/current_version.gni
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/h2o/LaunchTest.java
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserLauncher.java
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserLauncherParams.java
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/H2OLauncher.java
[modify] https://crrev.com/a336dd09327ff666da1042309c4b07ab7849c85a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/H2OTransparentLauncherActivity.java

Blockedon: 902559
I'd love to make squoosh.app a share target for images, so if you're looking for a site to demo it on, let me know.
That's awesome! It'll be a while before we're ready to launch, but we'll keep you in the loop
Cc: xuethan@chromium.org
Owner: hartma...@chromium.org
Blockedon: 912548 912555
Also blocked on internal http://b/120852302
Blockedon: 914821
Blockedon: 914822
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment