Issue metadata
Sign in to add a comment
|
mash: WindowTreeHostMus doesn't update its display |
||||||||||||||||||||||||
Issue descriptionIt seems aura::WindowTreeHostMus::set_display_id() is only invoked when it's initialized (WindowTreeClient::OnTopLevelCreated()), however this should be updated when the regarding window moves to another display. This means Screen::GetDisplayNearestWindow() will return a wrong display (since it simply returns WindowTreeHostMus::GetDisplay()) -- and confuses some UI tests since EventInjector passes a wrong display id.
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6afac0314ce61cca7fc900430635233932547f72 commit 6afac0314ce61cca7fc900430635233932547f72 Author: Jun Mukai <mukai@chromium.org> Date: Fri Sep 21 01:25:30 2018 fix some TabDragController test for Mash This CL fixes a part of UI tests of TabDragController. - some cases RootWindow is wanted to set/clear/check the window properties when Mash is enabled, those test expectations should be fixed. - some tests expect Ash style organization of window, checking root window pointer to exist in a particular display. Unfortunately some of this isn't fully fixed due to an issue of crbug.com/885312 - BrowserFrameMash's change is needed for IsWindowPositionManaged() which is called on some test cases. This is basically what BrowserFrameAsh does. BUG= 885312 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: Ic2e76a7e25d5104b32a3449fb45f047deab4b0dd Reviewed-on: https://chromium-review.googlesource.com/1232685 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593042} [modify] https://crrev.com/6afac0314ce61cca7fc900430635233932547f72/chrome/browser/ui/views/frame/browser_frame_mash.cc [modify] https://crrev.com/6afac0314ce61cca7fc900430635233932547f72/chrome/browser/ui/views/frame/browser_frame_mash.h [modify] https://crrev.com/6afac0314ce61cca7fc900430635233932547f72/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sky@chromium.org
, Sep 19Status: Duplicate (was: Assigned)