New issue
Advanced search Search tips

Issue 885299 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature
Launch-Exp-Leadership: NA
Rollout-Type: Default



Sign in to add a comment

Implement Pointer Events getPredictedEvent API

Project Member Reported by eirage@chromium.org, Sep 18

Issue description

Please provide a link to your UX implementation review here before requesting review.
 
Cc: nzolghadr@chromium.org
Labels: -Type-Task Type-Launch-OWP
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f6d9d5aa78269cd323cd8e97280e2aba727c80

commit a7f6d9d5aa78269cd323cd8e97280e2aba727c80
Author: Ella Ge <eirage@chromium.org>
Date: Tue Oct 16 23:15:19 2018

Add PredictedEvents to WebCoalescedInputEvent

This CL adds a vector predicted_events_ to WebCoalescedInputEvent, to
support pointer event  getPredictedEvent API.
This CL also changes the InputEventPrediction class used for resampling
to also generate 3 predicted event even when resampling is disabled. The
3 predicted event will be generated by Kalman filter predictor for now,
but in the following CL (add accuracy metrics), we change it to be controll
by another flag, so we can gather accuracy data for different prediction
algorithms on finch without turning on resampling.


Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/CgFyxYikn6A

Bug: 885299
Change-Id: I89b50ceea2847ea501b04ceb0da58f03741c379d
Reviewed-on: https://chromium-review.googlesource.com/c/1232884
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600178}
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/content/renderer/input/input_event_prediction.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/content/renderer/input/input_event_prediction.h
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/content/renderer/input/input_event_prediction_unittest.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/content/renderer/input/main_thread_event_queue.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/content/renderer/input/scoped_web_input_event_with_latency_info.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/content/renderer/input/scoped_web_input_event_with_latency_info.h
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/third_party/blink/public/platform/web_coalesced_input_event.h
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/third_party/blink/renderer/platform/exported/web_coalesced_input_event.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/ui/events/blink/prediction/kalman_predictor.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/ui/events/blink/prediction/kalman_predictor.h
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/ui/events/blink/prediction/least_squares_predictor.cc
[modify] https://crrev.com/a7f6d9d5aa78269cd323cd8e97280e2aba727c80/ui/events/blink/prediction/least_squares_predictor.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c9eac5183c65b3b58cc9dbe071940f50c815e80

commit 5c9eac5183c65b3b58cc9dbe071940f50c815e80
Author: Ella Ge <eirage@chromium.org>
Date: Wed Oct 17 00:50:19 2018

Add getPredictedEvent API to PointerEvent

Adding getPredictedEvent API to the idl file of PointerEventInit and
getter method to PointerEvent idl.
Also add the plumbing and creation in EventHandler & PEM

Bug: 885299
Change-Id: I559aed3bc19221dec526dad753349616da3ff683
Reviewed-on: https://chromium-review.googlesource.com/c/1232019
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600211}
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/content/renderer/input/main_thread_event_queue_unittest.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/68dcf5eebde37173d4027fa8635e332711d2874a/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/idlharness.window-expected.txt
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_constructor.html
[add] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_getPredictedEvents_when_pointerlocked-manual.html
[add] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_predicted_events_attributes-manual.html
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/public/platform/web_coalesced_input_event.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event.idl
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event_factory.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event_factory.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event_factory_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/events/pointer_event_init.idl
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/frame/web_frame_widget_base.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/html/forms/internal_popup_menu.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/event_handler.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/event_handler_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/pointer_event_manager.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/pointer_event_manager.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/pointer_event_manager_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/touch_event_manager.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/input/touch_event_manager_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/layout/scrollbars_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/page/page_widget_delegate.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/page/page_widget_delegate.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/page/pointer_lock_controller.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/core/page/pointer_lock_controller.h
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/platform/exported/web_coalesced_input_event.cc
[modify] https://crrev.com/5c9eac5183c65b3b58cc9dbe071940f50c815e80/third_party/blink/renderer/platform/runtime_enabled_features.json5

Labels: -Type-Launch-OWP Type-Launch
Labels: MovedFromTypeLaunchOWP
Labels: OS-Windows Rollout-Type-Default
Labels: Launch-Exp-Leadership-NA
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Labels: -Type-Launch Type-FLT-Launch FLT-Conversion
Automatic generating of FLT Launch data.
Labels: Restrict-View-Google
Labels: FLT-Conversion-1
Please do not modify this value.
Updating this issue's FLT-Conversion label.
Labels: Type-Feature
Labels: -Restrict-View-Google
Bulk updating old OWP-Launch bugs to once again be public. OWP-Launch (previously used as public/transparent blink launch process) was not supposed to have been remapped to Type=Launch.
Labels: Type-FLT-Launch
Preparing this issue to be converted back into the old format.

Will change Type back to 'Feature' after.
Labels: FLT-Conversion
Labels: Type-Feature
Labels: Type-FLT-Launch
Labels: Type-Feature
Summary: Implement Pointer Events getPredictedEvent API (was: Implement Pointer Events getPredictedEcent API)

Sign in to add a comment