Polymer2 migration: Eliminate obsolete "listeners" syntax. |
||||||
Issue description
The following files
md_downloads/manager.js
settings/controls/settings_textarea.js
settings/privacy_page/privacy_page.js
settings/settings_menu/settings_menu.js
are using the following pattern to register listeners
listeners: {
'id.eventName': 'onEventName_',
},
This is no longer supported in Polymer 2, and needs to be removed, see https://www.polymer-project.org/2.0/docs/upgrade#removed-apis.
,
Sep 18
,
Sep 19
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/313f2201ef5acf8d8185e215b1d8c054632860cc commit 313f2201ef5acf8d8185e215b1d8c054632860cc Author: dpapad <dpapad@chromium.org> Date: Wed Sep 19 19:22:39 2018 Settings WebUI: Fix navigation menu clicks in Polymer 2. In Polymer 2 the following syntax for registering event listeners is no longer supported. listeners: { 'id.eventName': 'onEventName_', }, Bug: 885294 Change-Id: I143aea45aab7ccb237f9034b04be5882ef7b8de0 Reviewed-on: https://chromium-review.googlesource.com/1231926 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592510} [modify] https://crrev.com/313f2201ef5acf8d8185e215b1d8c054632860cc/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/313f2201ef5acf8d8185e215b1d8c054632860cc/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/313f2201ef5acf8d8185e215b1d8c054632860cc/testing/buildbot/filters/webui_polymer2_browser_tests.filter
,
Sep 20
,
Sep 20
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e06bbddca10436a896a20872eb186c456939da7 commit 3e06bbddca10436a896a20872eb186c456939da7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Sep 24 20:09:57 2018 Settings: fix event handling for Polymer 2 The feature that allowed specifying an element id before the event name in the listeners object is no longer supported in Polymer 2. For example: listeners: { 'id.eventName': 'onEventName_', } Bug: 885294 Change-Id: Ieb468d10ebdc3ba436fdc38b8858b6a1b237e93f Reviewed-on: https://chromium-review.googlesource.com/1237400 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#593655} [modify] https://crrev.com/3e06bbddca10436a896a20872eb186c456939da7/chrome/browser/resources/md_downloads/manager.html [modify] https://crrev.com/3e06bbddca10436a896a20872eb186c456939da7/chrome/browser/resources/md_downloads/manager.js [modify] https://crrev.com/3e06bbddca10436a896a20872eb186c456939da7/chrome/browser/resources/settings/controls/settings_textarea.html [modify] https://crrev.com/3e06bbddca10436a896a20872eb186c456939da7/chrome/browser/resources/settings/controls/settings_textarea.js [modify] https://crrev.com/3e06bbddca10436a896a20872eb186c456939da7/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/3e06bbddca10436a896a20872eb186c456939da7/chrome/browser/resources/settings/privacy_page/privacy_page.js
,
Sep 24
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Sep 18