WebFrameWebStateObserverInttest fails with WKBasedNavigationManager |
||
Issue descriptionWebFrameWebStateObserverInttest are failing with WKBasedNavigationManager: WebFrameWebStateObserverInttest.SingleWebFrameHTTPS WebFrameWebStateObserverInttest.SingleWebFrameHTTP WebFrameWebStateObserverInttest.TwoWebFrameHTTPS Example failure logs: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/ios-simulator/94161
,
Sep 18
Likely. I need to dig a bit more to confirm.
,
Sep 25
I tried these tests today and they are no longer failing. I think they are fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1234268. I'll parameterize these tests so they will run both navigation manager implementations.
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ba729b14ac02174e7628168b2b9f91e0d296a4e commit 0ba729b14ac02174e7628168b2b9f91e0d296a4e Author: Danyao Wang <danyao@chromium.org> Date: Thu Sep 27 20:56:34 2018 [Nav Experiment] Parameterize WebFrameWebStateObserverInttest on nav manager Bug: 885274 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iead2e9e13997d6d12987c4a40e02876d55108523 Reviewed-on: https://chromium-review.googlesource.com/1244596 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#594852} [modify] https://crrev.com/0ba729b14ac02174e7628168b2b9f91e0d296a4e/ios/web/web_state/web_frame_web_state_observer_inttest.mm
,
Sep 27
|
||
►
Sign in to add a comment |
||
Comment 1 by michaeldo@chromium.org
, Sep 18