New issue
Advanced search Search tips

Issue 885261 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Sep 18
Cc:
omrilio@chromium.org
mccanny@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fling to close an overview window makes the splitview divider bar unusable

Project Member Reported by x...@chromium.org, Sep 18 
Chrome Version: (copy from chrome://version)
OS: Chrome

What steps will reproduce the problem?
(1) Open a few windows, Enter tablet mode and enter overview
(2) Drag one of the overview window to snap to left.
(3) Fling up or down to close one of the overview window
(4) Select another overview window to snap to right

What is the expected result?
The splitview divider bar should be usable

What happens instead?
The divider bar is unusable.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f217e8a7ac45391967e3dee367d1a730a5a79f47

commit f217e8a7ac45391967e3dee367d1a730a5a79f47
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Tue Sep 18 21:51:43 2018

overview: End window drag for fling event.

For fling event, we also should do proper drag ending if splitview mode is
active at the moment. Otherwise, the splitview divider bar won't be able to
place on top properly.

Bug:  885261 
Change-Id: I992c2502090c2f4d6fd9e4f0401ca172f9041823
Reviewed-on: https://chromium-review.googlesource.com/1231893
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592213}
[modify] https://crrev.com/f217e8a7ac45391967e3dee367d1a730a5a79f47/ash/wm/overview/overview_window_drag_controller.cc

Comment 2 by x...@chromium.org, Sep 18

Status: Fixed (was: Assigned)

Comment 3 by x...@chromium.org, Sep 18

Labels: Merge-Request-70

Comment 4 by mccanny@google.com, Sep 18

Cc: -mccanny@google.com mccanny@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 19

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by geo...@google.com, Sep 24

Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 24

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc82a720740a2348c4ca696e5c36aa9747ba463f

commit fc82a720740a2348c4ca696e5c36aa9747ba463f
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Sep 24 20:49:26 2018

[merge to M70] overview: End window drag for fling event.

For fling event, we also should do proper drag ending if splitview mode is
active at the moment. Otherwise, the splitview divider bar won't be able to
place on top properly.

Bug:  885261 
TBR=minch@chromium.org

Change-Id: I992c2502090c2f4d6fd9e4f0401ca172f9041823
Reviewed-on: https://chromium-review.googlesource.com/1231893
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592213}(cherry picked from commit f217e8a7ac45391967e3dee367d1a730a5a79f47)
Reviewed-on: https://chromium-review.googlesource.com/1241456
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#595}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/fc82a720740a2348c4ca696e5c36aa9747ba463f/ash/wm/overview/overview_window_drag_controller.cc
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Sep 24

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/fc82a720740a2348c4ca696e5c36aa9747ba463f

Commit: fc82a720740a2348c4ca696e5c36aa9747ba463f
Author: xdai@chromium.org
Commiter: xdai@chromium.org
Date: 2018-09-24 20:49:26 +0000 UTC

[merge to M70] overview: End window drag for fling event.

For fling event, we also should do proper drag ending if splitview mode is
active at the moment. Otherwise, the splitview divider bar won't be able to
place on top properly.

Bug:  885261 
TBR=minch@chromium.org

Change-Id: I992c2502090c2f4d6fd9e4f0401ca172f9041823
Reviewed-on: https://chromium-review.googlesource.com/1231893
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592213}(cherry picked from commit f217e8a7ac45391967e3dee367d1a730a5a79f47)
Reviewed-on: https://chromium-review.googlesource.com/1241456
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#595}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
►

Sign in to add a comment