New issue
Advanced search Search tips

Issue 885259 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Update message to say M71

Project Member Reported by rtoy@chromium.org, Sep 18

Issue description

Re-enabling the autoplay policy for WebAudio has been postponed from
M70 to M71.  The console warning needs to be updated.
 
Status: Fixed (was: Started)
Forgot to create the bug for this, but the CL has landed:  https://chromium-review.googlesource.com/c/chromium/src/+/1227403
Labels: -Pri-3 Target-70 Merge-Request-70 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Would be great to have this in M70.  It's basically a 1 character change, but lots of test expectations needed to be updated since the expectations include the warning message.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 18

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a889d9e2fa1a2513cd210cf24adbbbface3aae

commit 33a889d9e2fa1a2513cd210cf24adbbbface3aae
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Sep 18 22:19:11 2018

Update autoplay warning to M71

Re-enabling the autoplay policy for WebAudio has been postponed from
M70 to M71. Update the warning message to reflect that.

Change-Id: I579e9fc1eaddcf512297b871347b7c181b822703
Reviewed-on: https://chromium-review.googlesource.com/1227403
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591570}
(cherry picked from commit 292e4df1205b550c2c5eb7edb46fc2104274d999)

TBR=rtoy@chromium.org

Bug:  885259 
Change-Id: I5df5e4f7c61d8b4b2273be42ea73b29d3a39ba62
Reviewed-on: https://chromium-review.googlesource.com/1232373
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#510}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-allowed-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-cross-origin-with-credentials-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-redirect-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/http/tests/security/media-element-audio-source-node-same-origin-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/webaudio/internals/audiocontext-lock-threading-race-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-gc-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/webaudio/internals/mediaelementaudiosourcenode-wrapper-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/33a889d9e2fa1a2513cd210cf24adbbbface3aae/third_party/blink/renderer/modules/webaudio/audio_context.cc

Sign in to add a comment