Record metrics when passwords are accessed |
||
Issue descriptionPasswordManager.AccessPasswordInSettings records when users view or copy (on iOS) a password in the settings. It's not however recorded on Android. I think it should.
,
Sep 20
(https://crrev.com/c/1236001 is in flight for fixing the labels for the username and password-related histograms.)
,
Sep 20
I think that having PasswordManager.AccessPasswordInSettings on Android in addition to the current histograms is beneficial.
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1191b9d3bff53590c4e11cc17e3a66c6b81ac45b commit 1191b9d3bff53590c4e11cc17e3a66c6b81ac45b Author: Vaclav Brozek <vabr@chromium.org> Date: Mon Sep 24 13:13:37 2018 Fix PasswordCredentialEntry enum values The histograms PasswordManager.Android.PasswordCredentialEntry.Password and PasswordManager.Android.PasswordCredentialEntry.Username do have defined corresponding enums, but the histograms.xml file has a copy-paste mistake linking those to a wrong enum. This leads in wrong labels in the UMA dashboard. This CL corrects the association to the enum. It also replaces melandory@ with vabr@ as the owner of histograms for this area, because melandory@ changed teams last year. Bug: 885245 Change-Id: I0e53feb7c17ebbd63d9537bafa05fbd26138e728 Reviewed-on: https://chromium-review.googlesource.com/1236001 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593517} [modify] https://crrev.com/1191b9d3bff53590c4e11cc17e3a66c6b81ac45b/tools/metrics/histograms/histograms.xml
,
Nov 29
vabr going hobby only -> reducing involvement. Please contact me directly in urgent matters. |
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Sep 20