New issue
Advanced search Search tips

Issue 885244 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

[a11y] ChromeVox next object commands don't work as intended on Google search a11y bar

Project Member Reported by kkaja@google.com, Sep 18 
Version: 70.0.3538.16
Reproduction Steps: 
1. ChromeVox on
2. Go to google.com and search for puppies
3. At the top go to the "accessibility links" heading
4. Use Search+Right arrow to move through the items.

Observed: after the last link in the a11y bar, "accessibility feedback", the ChromeVox focus returns to the first link which is "skip to content".

Expected: Focus should move to the next item on the page.

This works as intended when using the tab key.

Comment 1 by dtseng@chromium.org, Sep 19 

There's something unusual about the "Accessibility feedback" link. When focused, it is destroyed from the accessibility tree. Either the page or Chrome is doing something wrong here.

Comment 2 by dsexton@chromium.org, Sep 20

Status: Available (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04639cbc23862a8085a75b310dc12669dab0d3d2

commit 04639cbc23862a8085a75b310dc12669dab0d3d2
Author: David Tseng <dtseng@chromium.org>
Date: Mon Oct 08 14:55:41 2018

Use tree path based recovery by default

Currently, ChromeVox recovers to ancestors when nodes are deleted from the accessibility tree.

This often times does not do exactly what we want. For example, when a page quickly removes and re-inserts a the same or similar node, ChromeVox loses its place. This also can lead to ChromeVox getting "stuck" in a navigational loop.

Tree path based recovery is already used within editable text, so has good coverage. TreePathRecoveryStrategy (the class) is also a subclass of AncestorRecoveryStrategy, so it falls back to ancestry-based recovery when the tree path is invalid.

An alternate approach was tried in:
https://chromium-review.googlesource.com/c/chromium/src/+/1234856

Test: the new Google.com accessibility menu now does not loop when navigating with ChromeVox.
Bug: 869914,885244
Change-Id: I129e2b31250c2f3169feb662b042e6900f61e424
Reviewed-on: https://chromium-review.googlesource.com/c/1262435
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597562}
[modify] https://crrev.com/04639cbc23862a8085a75b310dc12669dab0d3d2/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/04639cbc23862a8085a75b310dc12669dab0d3d2/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f253ae8c75d9235ccabb910c684698b578e58007

commit f253ae8c75d9235ccabb910c684698b578e58007
Author: David Tseng <dtseng@chromium.org>
Date: Wed Oct 17 16:52:30 2018

Avoid crash when dereferencing nullptr when getting child tree root

Bug: 885244,893396
Change-Id: I4ab6c6890af83483514edd41f1e7d2aeb38e4a4a
Reviewed-on: https://chromium-review.googlesource.com/c/1286814
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600428}
[modify] https://crrev.com/f253ae8c75d9235ccabb910c684698b578e58007/chrome/renderer/extensions/automation_internal_custom_bindings.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8b6beba81abc22134a5857a7c748f6681dad9b7

commit d8b6beba81abc22134a5857a7c748f6681dad9b7
Author: David Tseng <dtseng@chromium.org>
Date: Wed Oct 17 22:59:40 2018

Reland Use tree path based recovery by default

This reverts commit 697307bb63fb21799df6324099756762f6c5e0f9.

TBR=dmazzoni,chrishall

Bug: 885244,893396
Change-Id: I54ea0a3a8e71e7da39078245318608cc66c28c93
Reviewed-on: https://chromium-review.googlesource.com/c/1286815
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600586}
[modify] https://crrev.com/d8b6beba81abc22134a5857a7c748f6681dad9b7/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/d8b6beba81abc22134a5857a7c748f6681dad9b7/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
►

Sign in to add a comment