A11y: labels, tab navigation, and button toggling for FAR |
|||||||||||||||
Issue descriptionThere are several accessibility issues with the current FAR dialog: - Icons don't have labels for screen reader (all say "com dot") - Cannot navigate between entries with keyboard (using tab) - Cannot toggle app to install / not install with keyboard - Need announcement of title on screen load
,
Sep 20
,
Sep 20
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c953d1ca4e62352cc615545419356b7f681ed2d commit 9c953d1ca4e62352cc615545419356b7f681ed2d Author: Yue Cen <rsgingerrs@chromium.org> Date: Mon Sep 24 20:56:08 2018 Fast app reinstall: Fix A11y issues - Screen reader will read the app name when the chip is focused. - Navigate chips using tab. - Toggle app to install / not install with space or enter key. - Screen reader will read the title of recommend-apps and app-dowloading screens. Bug: 885219 Change-Id: I5ad9f79b33ae8a55fe4f5240692261e346461a22 Reviewed-on: https://chromium-review.googlesource.com/1234237 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593670} [modify] https://crrev.com/9c953d1ca4e62352cc615545419356b7f681ed2d/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js [modify] https://crrev.com/9c953d1ca4e62352cc615545419356b7f681ed2d/chrome/browser/resources/chromeos/login/app_downloading.html [modify] https://crrev.com/9c953d1ca4e62352cc615545419356b7f681ed2d/chrome/browser/resources/chromeos/login/app_downloading.js
,
Oct 9
,
Oct 10
,
Oct 10
,
Oct 10
I found a bug of the focused state so reopened this thread. The bug is: When the user uses keyboard to navigate through the chips, the focused chip has a border, which is normal. But if the user clicks a chip, there's a chance that the border will show up for the chip.
,
Oct 10
Also +kellylambert to see if the styling is correct for the focused state.
,
Oct 10
+ elizabethchiu@ for UI guidance Hi Elizabeth, we're not sure what the preferred visual design is for this state in the CrOS SUW. We're seeing multiple keyboard focused states on other SUW screens: yellow outline, fuzzy blue outline, and light gray overlay.
,
Oct 10
,
Oct 12
Gentle ping on this one :)
,
Oct 17
For the focus ring, instead of using yellow, it should be Google blue 600 50% opacity, 2 dp for the thickness.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753cc316eb81dde076a3dd41d9255134287ea229 commit 753cc316eb81dde076a3dd41d9255134287ea229 Author: Yue Cen <rsgingerrs@chromium.org> Date: Fri Oct 19 20:00:00 2018 Focus state should only be shown when navigating using keyboard Bug: 885219 Change-Id: Ib8ea8ac12fa782636577dc793281e81b9f48253b Reviewed-on: https://chromium-review.googlesource.com/c/1290196 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601267} [modify] https://crrev.com/753cc316eb81dde076a3dd41d9255134287ea229/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css [modify] https://crrev.com/753cc316eb81dde076a3dd41d9255134287ea229/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js
,
Oct 19
Request to merge the CL in comment#15 into M71. Thanks!
,
Oct 20
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f130f4faf1ccbc10fe033eb630e27a6997894ef3 commit f130f4faf1ccbc10fe033eb630e27a6997894ef3 Author: Yue Cen <rsgingerrs@chromium.org> Date: Tue Oct 23 21:30:56 2018 [Merge to M71] Focus state should only be shown when navigating using keyboard TBR=rsgingerrs@chromium.org (cherry picked from commit 753cc316eb81dde076a3dd41d9255134287ea229) Bug: 885219 Change-Id: Ib8ea8ac12fa782636577dc793281e81b9f48253b Reviewed-on: https://chromium-review.googlesource.com/c/1290196 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601267} Reviewed-on: https://chromium-review.googlesource.com/c/1297397 Reviewed-by: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#275} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/f130f4faf1ccbc10fe033eb630e27a6997894ef3/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.css [modify] https://crrev.com/f130f4faf1ccbc10fe033eb630e27a6997894ef3/chrome/browser/resources/chromeos/arc_support/recommend_app_list_view.js
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f130f4faf1ccbc10fe033eb630e27a6997894ef3 Commit: f130f4faf1ccbc10fe033eb630e27a6997894ef3 Author: rsgingerrs@chromium.org Commiter: rsgingerrs@chromium.org Date: 2018-10-23 21:30:56 +0000 UTC [Merge to M71] Focus state should only be shown when navigating using keyboard TBR=rsgingerrs@chromium.org (cherry picked from commit 753cc316eb81dde076a3dd41d9255134287ea229) Bug: 885219 Change-Id: Ib8ea8ac12fa782636577dc793281e81b9f48253b Reviewed-on: https://chromium-review.googlesource.com/c/1290196 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601267} Reviewed-on: https://chromium-review.googlesource.com/c/1297397 Reviewed-by: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#275} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 8
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by weifangsun@chromium.org
, Sep 18Status: Assigned (was: Untriaged)