Extensions Click-to-Script: Add context menu metrics |
||||||
Issue descriptionAdd metrics for the action taken (if any) from the extension context menu. This is most immediately interesting for click-to-script, but also quite useful for other insights.
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b9706d935f92b2e90824ca37c16b0fddb13e4df commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Sep 25 00:46:24 2018 Click to script: Record metrics for action chosen through extension icon context menu. This CL adds metrics for the action taken by the user through the extension icon context menu. BUG= 885201 Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 Reviewed-on: https://chromium-review.googlesource.com/1239217 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593782} [modify] https://crrev.com/6b9706d935f92b2e90824ca37c16b0fddb13e4df/chrome/browser/extensions/extension_context_menu_model.cc [modify] https://crrev.com/6b9706d935f92b2e90824ca37c16b0fddb13e4df/chrome/browser/extensions/extension_context_menu_model.h [modify] https://crrev.com/6b9706d935f92b2e90824ca37c16b0fddb13e4df/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/6b9706d935f92b2e90824ca37c16b0fddb13e4df/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6b9706d935f92b2e90824ca37c16b0fddb13e4df/tools/metrics/histograms/histograms.xml
,
Sep 25
,
Sep 25
Requesting merge to M70. This adds metrics for runtime host permissions experiment. It should be safe to merge.
,
Sep 25
Have you verified this in canary?
,
Sep 25
Verified this in Canary.
,
Sep 25
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e2bd02bd4b229526d944389441ea7c7bad140c9 commit 0e2bd02bd4b229526d944389441ea7c7bad140c9 Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Sep 25 21:36:11 2018 [Merge M70] Click to script: Record metrics for action chosen through extension icon context menu. This CL adds metrics for the action taken by the user through the extension icon context menu. TBR=rdevlin.cronin@chromium.org BUG= 885201 Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 Reviewed-on: https://chromium-review.googlesource.com/1239217 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593782}(cherry picked from commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df) Reviewed-on: https://chromium-review.googlesource.com/1244716 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#668} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/0e2bd02bd4b229526d944389441ea7c7bad140c9/chrome/browser/extensions/extension_context_menu_model.cc [modify] https://crrev.com/0e2bd02bd4b229526d944389441ea7c7bad140c9/chrome/browser/extensions/extension_context_menu_model.h [modify] https://crrev.com/0e2bd02bd4b229526d944389441ea7c7bad140c9/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/0e2bd02bd4b229526d944389441ea7c7bad140c9/tools/metrics/histograms/enums.xml [modify] https://crrev.com/0e2bd02bd4b229526d944389441ea7c7bad140c9/tools/metrics/histograms/histograms.xml
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e2bd02bd4b229526d944389441ea7c7bad140c9 Commit: 0e2bd02bd4b229526d944389441ea7c7bad140c9 Author: karandeepb@chromium.org Commiter: karandeepb@chromium.org Date: 2018-09-25 21:36:11 +0000 UTC [Merge M70] Click to script: Record metrics for action chosen through extension icon context menu. This CL adds metrics for the action taken by the user through the extension icon context menu. TBR=rdevlin.cronin@chromium.org BUG= 885201 Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 Reviewed-on: https://chromium-review.googlesource.com/1239217 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593782}(cherry picked from commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df) Reviewed-on: https://chromium-review.googlesource.com/1244716 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#668} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baeb23d39c609c2a37deaf632648a19cde769322 commit baeb23d39c609c2a37deaf632648a19cde769322 Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Sep 25 23:29:41 2018 Revert "[Merge M70] Click to script: Record metrics for action chosen through extension icon context menu." This reverts commit 0e2bd02bd4b229526d944389441ea7c7bad140c9. Reason for revert: Broke build. Requires a pre-requisite CL. Original change's description: > [Merge M70] Click to script: Record metrics for action chosen through extension icon context menu. > > This CL adds metrics for the action taken by the user through the extension icon > context menu. > > TBR=rdevlin.cronin@chromium.org > BUG= 885201 > > Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 > Reviewed-on: https://chromium-review.googlesource.com/1239217 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#593782}(cherry picked from commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df) > Reviewed-on: https://chromium-review.googlesource.com/1244716 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/branch-heads/3538@{#668} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=karandeepb@chromium.org Change-Id: Ic51546403e1b47f8d11deecd26f4982992d80ce8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 885201 Reviewed-on: https://chromium-review.googlesource.com/1244877 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#674} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/baeb23d39c609c2a37deaf632648a19cde769322/chrome/browser/extensions/extension_context_menu_model.cc [modify] https://crrev.com/baeb23d39c609c2a37deaf632648a19cde769322/chrome/browser/extensions/extension_context_menu_model.h [modify] https://crrev.com/baeb23d39c609c2a37deaf632648a19cde769322/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/baeb23d39c609c2a37deaf632648a19cde769322/tools/metrics/histograms/enums.xml [modify] https://crrev.com/baeb23d39c609c2a37deaf632648a19cde769322/tools/metrics/histograms/histograms.xml
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/baeb23d39c609c2a37deaf632648a19cde769322 Commit: baeb23d39c609c2a37deaf632648a19cde769322 Author: karandeepb@chromium.org Commiter: karandeepb@chromium.org Date: 2018-09-25 23:29:41 +0000 UTC Revert "[Merge M70] Click to script: Record metrics for action chosen through extension icon context menu." This reverts commit 0e2bd02bd4b229526d944389441ea7c7bad140c9. Reason for revert: Broke build. Requires a pre-requisite CL. Original change's description: > [Merge M70] Click to script: Record metrics for action chosen through extension icon context menu. > > This CL adds metrics for the action taken by the user through the extension icon > context menu. > > TBR=rdevlin.cronin@chromium.org > BUG= 885201 > > Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 > Reviewed-on: https://chromium-review.googlesource.com/1239217 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#593782}(cherry picked from commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df) > Reviewed-on: https://chromium-review.googlesource.com/1244716 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/branch-heads/3538@{#668} > Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} TBR=karandeepb@chromium.org Change-Id: Ic51546403e1b47f8d11deecd26f4982992d80ce8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 885201 Reviewed-on: https://chromium-review.googlesource.com/1244877 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#674} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01e57246b9df7ad5bc179d440eac9c5b1b98c740 commit 01e57246b9df7ad5bc179d440eac9c5b1b98c740 Author: Karandeep Bhatia <karandeepb@chromium.org> Date: Wed Sep 26 18:30:33 2018 [Merge M70] Click to script: Record metrics for action chosen through extension icon context menu. This CL adds metrics for the action taken by the user through the extension icon context menu. This also requires commits 94aa4fbb1bf03db09b0b191cb1f4f1ccc3f094dc and f4ab46c9b1e917bd616d09d9b97e6388c1ffad39 as pre-requisities, which don't introduce any behavior changes. TBR=rdevlin.cronin@chromium.org, avi@chromium.org, sky@chromium.org BUG= 885201 Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 Reviewed-on: https://chromium-review.googlesource.com/1239217 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593782} (cherry picked from commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df) [Extensions] Update ExtensionContextMenuModel::MenuEntries names A few of the name values for the menu entries in the ExtensionContextMenuModel were a little misleading. Remap the following (<old> -> <new>): - NAME -> HOME_PAGE (opens the extension's home page, or the webstore if a separate home page was not specified). - CONFIGURE - OPTIONS (opens the extension's options page) - MANAGE -> MANAGE_EXTENSIONS (opens the chrome://extensions page) No functional change is intended; this is purely a renaming of code values. Bug: None Change-Id: Iabac73bf3bd7d85ea02b23379a9a19eeef02cf21 Reviewed-on: https://chromium-review.googlesource.com/1229774 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593082} (cherry picked from commit 94aa4fbb1bf03db09b0b191cb1f4f1ccc3f094dc) [UI] Resolve method conflict between MenuModel, SimpleMenuModel::Delegate ui::MenuModel (which ui::SimpleMenuModel inherits from) declares a virtual method, `void MenuWillShow()`. SimpleMenuModel::Delegate declares a similar method, `void MenuWillShow(SimpleMenuModel*)`. This results in a conflict for any class that inherits from both SimpleMenuModel and SimpleMenuModel::Delegate (which is not uncommon). Resolve this by renaming the SimpleMenuModel::Delegate version to `void SimpleMenuWillShow(SimpleMenuModel*)`. (cherry picked from commit f4ab46c9b1e917bd616d09d9b97e6388c1ffad39) Bug: 885198 Change-Id: I0581991fa7a12368007f6c082c461acb4833750c Reviewed-on: https://chromium-review.googlesource.com/1230581 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592694} Reviewed-on: https://chromium-review.googlesource.com/1246683 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#688} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/extensions/extension_context_menu_model.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/extensions/extension_context_menu_model.h [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/extensions/extension_context_menu_model_unittest.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/renderer_context_menu/mock_render_view_context_menu.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/renderer_context_menu/mock_render_view_context_menu.h [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/ui/toolbar/media_router_contextual_menu.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/ui/toolbar/media_router_contextual_menu.h [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/components/renderer_context_menu/render_view_context_menu_base.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/components/renderer_context_menu/render_view_context_menu_base.h [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/tools/metrics/histograms/enums.xml [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/ui/base/cocoa/menu_controller_unittest.mm [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/ui/base/models/simple_menu_model.cc [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/ui/base/models/simple_menu_model.h [modify] https://crrev.com/01e57246b9df7ad5bc179d440eac9c5b1b98c740/ui/views/controls/menu/menu_runner_cocoa_unittest.mm
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01e57246b9df7ad5bc179d440eac9c5b1b98c740 Commit: 01e57246b9df7ad5bc179d440eac9c5b1b98c740 Author: karandeepb@chromium.org Commiter: karandeepb@chromium.org Date: 2018-09-26 18:30:33 +0000 UTC [Merge M70] Click to script: Record metrics for action chosen through extension icon context menu. This CL adds metrics for the action taken by the user through the extension icon context menu. This also requires commits 94aa4fbb1bf03db09b0b191cb1f4f1ccc3f094dc and f4ab46c9b1e917bd616d09d9b97e6388c1ffad39 as pre-requisities, which don't introduce any behavior changes. TBR=rdevlin.cronin@chromium.org, avi@chromium.org, sky@chromium.org BUG= 885201 Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 Reviewed-on: https://chromium-review.googlesource.com/1239217 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593782} (cherry picked from commit 6b9706d935f92b2e90824ca37c16b0fddb13e4df) [Extensions] Update ExtensionContextMenuModel::MenuEntries names A few of the name values for the menu entries in the ExtensionContextMenuModel were a little misleading. Remap the following (<old> -> <new>): - NAME -> HOME_PAGE (opens the extension's home page, or the webstore if a separate home page was not specified). - CONFIGURE - OPTIONS (opens the extension's options page) - MANAGE -> MANAGE_EXTENSIONS (opens the chrome://extensions page) No functional change is intended; this is purely a renaming of code values. Bug: None Change-Id: Iabac73bf3bd7d85ea02b23379a9a19eeef02cf21 Reviewed-on: https://chromium-review.googlesource.com/1229774 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593082} (cherry picked from commit 94aa4fbb1bf03db09b0b191cb1f4f1ccc3f094dc) [UI] Resolve method conflict between MenuModel, SimpleMenuModel::Delegate ui::MenuModel (which ui::SimpleMenuModel inherits from) declares a virtual method, `void MenuWillShow()`. SimpleMenuModel::Delegate declares a similar method, `void MenuWillShow(SimpleMenuModel*)`. This results in a conflict for any class that inherits from both SimpleMenuModel and SimpleMenuModel::Delegate (which is not uncommon). Resolve this by renaming the SimpleMenuModel::Delegate version to `void SimpleMenuWillShow(SimpleMenuModel*)`. (cherry picked from commit f4ab46c9b1e917bd616d09d9b97e6388c1ffad39) Bug: 885198 Change-Id: I0581991fa7a12368007f6c082c461acb4833750c Reviewed-on: https://chromium-review.googlesource.com/1230581 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#592694} Reviewed-on: https://chromium-review.googlesource.com/1246683 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#688} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by karandeepb@chromium.org
, Sep 21Owner: karandeepb@chromium.org