The tree looks like:

<div style="width: 512px; height: 300px">
  <iframe style="width: 100%; height: 100%; ..."></iframe>
</div>

but NG computes the height of the iframe to 0px. Setting "height: 300px" to the iframe shows the content.

Ian, Morten, Christian, does this give you some ideas?

I don't get any confirmation dialog when hitting "send", apart from the blank subject warning.

Hm, maybe you need to send to someone who doesn't have access to the inserted link yet?

Got it to fail now. I tried various combinations yesterday without success.

 Issue 879747  has been merged into this issue.

The problem is in AdjustChildPercentageSizeForQuirksAndFlex(), which ignores the fixed size of the flex item. Making it honor it makes this bug go away (but that's highly unlikely to be the right fix).

 Issue 894339  has been merged into this issue.

The problem is that NGConstraintSpace::CreateFromLayoutObject only takes UseOverrideLogicalHeightForPerentageResolution into account for setting fixed_block_is_definite

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a70f8ae4b02206020caa4504a22fc37524e21bd

commit 8a70f8ae4b02206020caa4504a22fc37524e21bd
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Thu Nov 01 01:48:52 2018

[layoutng] Fix setting of fixed_block_is_definite

When a flex item has a definite specified height (e.g. height: 100px),
then percentages in children of the flex item should resolve even
if the flexbox does not have an explicit height, ie. does not match
the condition in https://drafts.csswg.org/css-flexbox/#definite-sizes

Bug:  885185 

Change-Id: Iba226f30e1e02e3a11273fa45fcdf1cef897120c
Reviewed-on: https://chromium-review.googlesource.com/c/1311534
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604483}
[modify] https://crrev.com/8a70f8ae4b02206020caa4504a22fc37524e21bd/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8a70f8ae4b02206020caa4504a22fc37524e21bd/third_party/WebKit/LayoutTests/external/wpt/css/css-flexbox/percentage-heights-005.html
[modify] https://crrev.com/8a70f8ae4b02206020caa4504a22fc37524e21bd/third_party/blink/renderer/core/layout/ng/ng_constraint_space.cc

Can someone confirm that devtools works now with this patch?

On Wed, Oct 31, 2018, 20:49 bugdroid1 via monorail <
monorail+v2.3275348242@chromium.org wrote: