New issue
Advanced search Search tips

Issue 885178 link

Starred by 2 users
Status: Fixed
Owner:
svil...@igalia.com
Closed: Oct 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 884205
Blocking:
issue 883318



Sign in to add a comment

Convert DesktopProfileSessionDurationsService from using PO2TS to using IdentityManager

Project Member Reported by blundell@chromium.org, Sep 18 
- It observes the PO2TS.
- It calls PO2TS::GetAccounts().

These should be easily convertible to using IdentityManager.

As part of this, the usage in the corresponding factory should naturally be eliminated.

Comment 1 by svil...@igalia.com, Sep 26

Status: Assigned (was: Available)
Taking this

Comment 2 by svil...@igalia.com, Sep 26

Owner: svil...@igalia.com

Comment 3 by blundell@chromium.org, Sep 26 

Hi Sergio! This bug needs  crbug.com/884205  in order to be pushed through. Are you interested in taking that one? If not, I can take it to unblock you here. Thanks!

Comment 4 by svil...@igalia.com, Sep 26 

Yeah I've just noticed it when migrating the Observer calls, I left a TODO there while completing the migration.

If the task is "just" to offer a similar API then yeah I guess I can take it over.

Comment 5 by blundell@chromium.org, Sep 26

Status: Started (was: Assigned)
Cool! Yes, I think it should be pretty clean to add in.

Comment 6 by svil...@igalia.com, Oct 8

Status: Fixed (was: Started)
Fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1261202

Forgot to add the bug number to the CL :(
►

Sign in to add a comment