New issue
Advanced search Search tips

Issue 885174 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Verify that WebHistoryServiceFactory //components/signin includes are stale and remove them

Project Member Reported by blundell@chromium.org, Sep 18

Issue description

Title says it all :).
 
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a872d4130fe9d04074b151c5cbaa047106b525cf

commit a872d4130fe9d04074b151c5cbaa047106b525cf
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Fri Oct 19 09:18:21 2018

Remove stale includes from WebHistoryServiceFactory

Neither SigninManager nor ProfileOAuth2TokenService are in use anymore,
we can safely remove them.

Bug:  885174 
Change-Id: I9ea858295b2bb868b7a8bdbb73ec34927041fbac
Reviewed-on: https://chromium-review.googlesource.com/c/1288438
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601086}
[modify] https://crrev.com/a872d4130fe9d04074b151c5cbaa047106b525cf/chrome/browser/history/web_history_service_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment