New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 885165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Disable BLE/caBLE transports on platforms that do not support it

Project Member Reported by engedy@chromium.org, Sep 18

Issue description

Disable caBLE support on platforms that do not support it: require at least Windows 10 or macOS 10.10.
 
Summary: Disable BLE/caBLE transports on platforms that do not support it (was: Disable caBLE support on platforms that do not support it)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/becfcc8ba8c77163d68634bbb3701880faf49e1a

commit becfcc8ba8c77163d68634bbb3701880faf49e1a
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Sep 20 11:54:32 2018

Disable BLE/caBLE transports on platforms that do not support it.

Bug:  885165 
Change-Id: I207457e481ef89ffcf0d91ee530cea2d3c33649a
Reviewed-on: https://chromium-review.googlesource.com/1230675
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592763}
[modify] https://crrev.com/becfcc8ba8c77163d68634bbb3701880faf49e1a/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/becfcc8ba8c77163d68634bbb3701880faf49e1a/content/browser/webauth/authenticator_impl_unittest.cc

Labels: -M70 Merge-Request-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 24

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
which oS is this impacting?
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 28

Cc: abdulsyed@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 1

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9c8f1663edd675c807086a6b9c8b51549cd657

commit 6a9c8f1663edd675c807086a6b9c8b51549cd657
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Oct 01 09:46:21 2018

Disable BLE/caBLE transports on platforms that do not support it.

(cherry picked from commit becfcc8ba8c77163d68634bbb3701880faf49e1a)

Bug:  885165 
Change-Id: I207457e481ef89ffcf0d91ee530cea2d3c33649a
Reviewed-on: https://chromium-review.googlesource.com/1230675
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592763}
Reviewed-on: https://chromium-review.googlesource.com/1253781
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#766}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/6a9c8f1663edd675c807086a6b9c8b51549cd657/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/6a9c8f1663edd675c807086a6b9c8b51549cd657/content/browser/webauth/authenticator_impl_unittest.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6a9c8f1663edd675c807086a6b9c8b51549cd657

Commit: 6a9c8f1663edd675c807086a6b9c8b51549cd657
Author: engedy@chromium.org
Commiter: engedy@chromium.org
Date: 2018-10-01 09:46:21 +0000 UTC

Disable BLE/caBLE transports on platforms that do not support it.

(cherry picked from commit becfcc8ba8c77163d68634bbb3701880faf49e1a)

Bug:  885165 
Change-Id: I207457e481ef89ffcf0d91ee530cea2d3c33649a
Reviewed-on: https://chromium-review.googlesource.com/1230675
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592763}
Reviewed-on: https://chromium-review.googlesource.com/1253781
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#766}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Started)

Sign in to add a comment