New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 885164 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

HostedAppOpaqueBrowserFrameViewTest.* failing on mac-cocoa-rel

Project Member Reported by asanka@chromium.org, Sep 18

Issue description

Started since https://chromium-review.googlesource.com/c/chromium/src/+/1218186

All tests introduced in that CL are failing.

Failures look like :

[ RUN      ] HostedAppOpaqueBrowserFrameViewTest.LightThemeColor
[15497:13831:0918/031904.601203:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
2018-09-18 03:19:04.699 browser_tests[15497:1393037] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
[15497:775:0918/031904.758361:ERROR:delegated_frame_host.cc(174)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool)
2018-09-18 03:19:05.223 browser_tests[15497:1393037] *** WARNING: Textured window <FramedBrowserWindow: 0x7facc97c7360> is getting an implicitly transparent titlebar. This will break when linking against newer SDKs. Use NSWindow's -titlebarAppearsTransparent=YES instead.
2018-09-18 03:19:05.252 browser_tests[15497:1393037] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
[15497:775:0918/031905.306046:ERROR:delegated_frame_host.cc(174)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool)
BrowserTestBase received signal: Segmentation fault: 11. Backtrace:
0   browser_tests                       0x0000000106c42f1c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x000000010723f695 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229
2   libsystem_platform.dylib            0x00007fff5d5c3f5a _sigtramp + 26
3   ???                                 0x00007facc9460958 0x0 + 140380087912792
4   browser_tests                       0x00000001045e9f9b HostedAppOpaqueBrowserFrameViewTest_LightThemeColor_Test::RunTestOnMainThread() + 27
5   browser_tests                       0x000000010723eb4b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491
6   browser_tests                       0x0000000106d00d31 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4481
7   browser_tests                       0x0000000106cffaae ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
8   browser_tests                       0x0000000105726a63 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
9   browser_tests                       0x0000000105b40007 content::StartupTaskRunner::RunAllTasksNow() + 39
10  browser_tests                       0x00000001057251b8 content::BrowserMainLoop::CreateStartupTasks() + 712
11  browser_tests                       0x0000000105728f80 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96
12  browser_tests                       0x00000001057232b4 content::BrowserMain(content::MainFunctionParams const&) + 180
13  browser_tests                       0x0000000106b1e5f2 content::ContentMainRunnerImpl::Run(bool) + 610
14  browser_tests                       0x0000000108c31891 service_manager::Main(service_manager::MainParams const&) + 2849
15  browser_tests                       0x0000000106b1d7e4 content::ContentMain(content::ContentMainParams const&) + 68
16  browser_tests                       0x000000010723e779 content::BrowserTestBase::SetUp() + 2841
17  browser_tests                       0x0000000106c7c385 InProcessBrowserTest::SetUp() + 517
18  browser_tests                       0x0000000104a64ccd testing::Test::Run() + 109
19  browser_tests                       0x0000000104a65950 testing::TestInfo::Run() + 304
20  browser_tests                       0x0000000104a65ec7 testing::TestCase::Run() + 279
21  browser_tests                       0x0000000104a71e57 testing::internal::UnitTestImpl::RunAllTests() + 871
22  browser_tests                       0x0000000104a71acd testing::UnitTest::Run() + 109
23  browser_tests                       0x0000000106c96ba6 base::TestSuite::Run() + 166
24  browser_tests                       0x0000000106b8021d ChromeTestSuiteRunner::RunTestSuite(int, char**) + 45
25  browser_tests                       0x0000000107261518 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 552
26  browser_tests                       0x0000000106b8079a LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 490
27  browser_tests                       0x0000000106b8018e main + 94
28  libdyld.dylib                       0x00007fff5d2b5015 start + 1
29  ???                                 0x000000000000000d 0x0 + 13
 
Labels: -Pri-3 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d

commit 545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d
Author: Asanka Herath <asanka@chromium.org>
Date: Tue Sep 18 16:27:45 2018

Revert "Fix inconsistent hosted app title bar text color readability algorithm"

This reverts commit 9c6ad3095f59d1378e785eb7c4289bf2c6edadd3.

Reason for revert: Tests added in this CL are failing on mac-cocoa-rel
 since landing.

Original change's description:
> Fix inconsistent hosted app title bar text color readability algorithm
> 
> This CL updates the title text color for Linux and Windows 7 hosted
> app windows to be more consistent with Windows 10, Chrome OS, Android
> and text colors used by Gmail and Inbox.
> 
> Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1
> After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1
> See bug for more screenshots.
> 
> Bug:  883177 
> Change-Id: Ic24e1cf0b445251ebfdcd1aa0ae74c9343b1ff8e
> Reviewed-on: https://chromium-review.googlesource.com/1218186
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591279}

TBR=jamescook@chromium.org,msw@chromium.org,alancutter@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  883177 
Bug:  885164 
Change-Id: I22a52611a5478ee1d430ccd8ca1a507f7237d4f7
Reviewed-on: https://chromium-review.googlesource.com/1230435
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592069}
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[delete] https://crrev.com/4e0dc98a4148183d1fcd770f0899a96354b25b06/chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/chrome/test/BUILD.gn
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/ui/gfx/color_utils.cc
[modify] https://crrev.com/545d0bf4e0f195bb58f1620a1ad6958a8a95ed9d/ui/gfx/color_utils.h

Labels: -Sheriff-Chromium
Oops, that test shouldn't be run on that bot. Need to update the build files.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c6415198fe67aad0461181ac5b544e0f08fe076

commit 9c6415198fe67aad0461181ac5b544e0f08fe076
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Sep 20 02:22:39 2018

Reland: Fix inconsistent hosted app title bar text color readability algorithm

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1218186
which was reverted in https://chromium-review.googlesource.com/1230435
due to the added test failing mac-cocoa-rel.
This reland removes the test from non-Views mac builds as it's only
applicable with Views enabled.

This CL updates the title text color for Linux and Windows 7 hosted
app windows to be more consistent with Windows 10, Chrome OS, Android
and text colors used by Gmail and Inbox.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1
See bug for more screenshots.

Bug:  883177 ,  885164 
Change-Id: Iaeae13799629d418dfa4c4285032bf1d7990c402
Reviewed-on: https://chromium-review.googlesource.com/1233074
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592661}
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[add] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/chrome/test/BUILD.gn
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/ui/gfx/color_utils.cc
[modify] https://crrev.com/9c6415198fe67aad0461181ac5b544e0f08fe076/ui/gfx/color_utils.h

Looks like this is still failing.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/1345 (you have to search the stdout).

Turns out mac-cocoa-rel has the mac_views_browser build flag enabled, it just disables Mac views with a runtime flag.

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/440f2144f9fc3f733d0bfefafeaeb11c780014d3

commit 440f2144f9fc3f733d0bfefafeaeb11c780014d3
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Sep 21 03:54:07 2018

Force Mac Views for HostedAppOpaqueBrowserFrameViewTest on mac-cocoa-rel

This CL makes HostedAppOpaqueBrowserFrameViewTest force enable Mac Views
to fix a crash on mac-cocoa-rel.

Bug:  885164 
Change-Id: I8cd754954c9119a65c8aca94b7a07f2159e3f95d
Reviewed-on: https://chromium-review.googlesource.com/1237733
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593073}
[modify] https://crrev.com/440f2144f9fc3f733d0bfefafeaeb11c780014d3/chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f5b467eb2f880fdcdc96a369572bacc578f5e0a

commit 4f5b467eb2f880fdcdc96a369572bacc578f5e0a
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Sep 21 04:00:53 2018

Reland: Fix inconsistent hosted app title bar text color readability algorithm

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1218186
which was reverted in https://chromium-review.googlesource.com/1230435
due to the added test failing mac-cocoa-rel.
This reland removes the test from non-Views mac builds as it's only
applicable with Views enabled.

This CL updates the title text color for Linux and Windows 7 hosted
app windows to be more consistent with Windows 10, Chrome OS, Android
and text colors used by Gmail and Inbox.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1
See bug for more screenshots.

Bug:  883177 ,  885164 
Change-Id: Iaeae13799629d418dfa4c4285032bf1d7990c402
Reviewed-on: https://chromium-review.googlesource.com/1233074
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592661}(cherry picked from commit 9c6415198fe67aad0461181ac5b544e0f08fe076)
Reviewed-on: https://chromium-review.googlesource.com/1237895
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#555}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[add] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/chrome/test/BUILD.gn
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/ui/gfx/color_utils.cc
[modify] https://crrev.com/4f5b467eb2f880fdcdc96a369572bacc578f5e0a/ui/gfx/color_utils.h

Status: Fixed (was: Assigned)
Labels: -merge-merged-3538
This label is just for https://bugs.chromium.org/p/chromium/issues/detail?id=883177.

Sign in to add a comment