New issue
Advanced search Search tips

Issue 885146 link

Starred by 1 user
Status: Assigned
Owner:
jkarlin@chromium.org
Cc:
japhet@chromium.org
ojan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Block top-frame navigations from same-origin ad frames without user gesture

Project Member Reported by jkarlin@chromium.org, Sep 18 
Now that AdTagging is shipping in M70 we can investigate whether it makes sense to block same-origin ad frames from navigating the top-frame without a user gesture.

Step one is to measure how often such navigations occur (UMA and UKM).

We already know that 44% of ad frames are same-origin. But it would be good to know how often those frames navigate the top-frame without user gesture to understand how big the problem is.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf4b444756424c83b7d6df2d3b20a6b49ccaf1d

commit eaf4b444756424c83b7d6df2d3b20a6b49ccaf1d
Author: Josh Karlin <jkarlin@chromium.org>
Date: Fri Sep 21 19:38:21 2018

[AdMetrics] Measure if top-frame navigations are coming from ad frames

What: Expand the WebCore.Framebust metric to also measure if the frame
initiating the navigation is an ad frame.

Why: It might be a good idea to prevent framebusting from same-origin
ad iframes without user gesture. This measurement will tell us how
common it is.

Bug: 885146
Change-Id: I6366094b119b6f220ac1a01ea43662423dc961ee
Reviewed-on: https://chromium-review.googlesource.com/1238778
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593304}
[modify] https://crrev.com/eaf4b444756424c83b7d6df2d3b20a6b49ccaf1d/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/eaf4b444756424c83b7d6df2d3b20a6b49ccaf1d/tools/metrics/histograms/enums.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aea63b97b28cc4db94c6417f1c035d4cdd8919b7

commit aea63b97b28cc4db94c6417f1c035d4cdd8919b7
Author: Josh Karlin <jkarlin@chromium.org>
Date: Wed Sep 26 04:32:28 2018

Rename WebCore.Framebust to WebCore.Framebust2 since its enum changed

Changing the enum of WebCore.Framebust (https://crrev.com/c/1238778)
was a significant enough change that it should be renamed so that we
can track it better.

Bug: 885146
Change-Id: Idff7ac9c6fafc5b1272b5f5f4dc91dd71fc09ef1
Reviewed-on: https://chromium-review.googlesource.com/1240973
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594216}
[modify] https://crrev.com/aea63b97b28cc4db94c6417f1c035d4cdd8919b7/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/aea63b97b28cc4db94c6417f1c035d4cdd8919b7/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/aea63b97b28cc4db94c6417f1c035d4cdd8919b7/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment