Issue metadata
Sign in to add a comment
|
"Cmd+T" shortcut doesn't work when wrench menu is open
Reported by
khushal....@etouch.net,
Sep 18
|
||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3554.0 (Official Build) Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} (64-bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14) What steps will reproduce the problem? (1) Launch chrome and click on 3-dot icon to open wrench menu. (2) Now press "Cmd+T" key and Observe. Actual Result: "Cmd+T" shortcut doesn't work when wrench menu is open. Expected Result: "Cmd+T" shortcut should open new tab even when wrench menu is open. This is a regression issue, broken in M-70 series, below is manual regression range: Good build: 70.0.3523.0 (Revision: 583084) Bad build: 70.0.3524.0 (Revision: 583420) Using 'Per-revision' script providing the bisect result below: You are probably looking for a change made after 583249 (known good), but no later than 583257 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/dfeb9d0e68e9dc46b17bffe8285587fba7bcba9d..8e737baf4519b48a0ff8bd239a45686412336e40 Suspecting: https://chromium.googlesource.com/chromium/src/+/8e737baf4519b48a0ff8bd239a45686412336e40 @ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Also, "Cmd+N" and "Shift+Cmd+N" shortcut brings grey focus highlight on 'New Tab' option of wrench menu. 2. Issue is also seen on M-71 Canary version 71.0.3555.0. 3. Issue is not seen on Windows (7, 8, 8.1, 10) and Linux (14.04 LTS). Kindly review the attached screen-cast. Thank you..!!
,
Sep 18
,
Sep 26
,
Sep 27
,
Sep 27
,
Nov 13
Hi, Just to update: Issue is still reproducible on Mac (10.13.1, 10.13.6, 10.14.2) OS using Latest canary #72.0.3608.4 Please find the screen shot for reference. @ellyjones: Could you please take a look in to this issue. Thank You!
,
Nov 13
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6 commit b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Nov 13 19:19:28 2018 views: close menus when accelerators are pressed on Mac This change: 1) Has MenuController consider command to be an accelerator key, along with control and alt, for the purpose of not searching for mnemonics; 2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing which tells the menu to close for an accelerator Bug: 885138 Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a Reviewed-on: https://chromium-review.googlesource.com/c/1334147 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607699} [modify] https://crrev.com/b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6/chrome/browser/ui/views/chrome_views_delegate.h [modify] https://crrev.com/b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6/chrome/browser/ui/views/chrome_views_delegate_mac.cc [modify] https://crrev.com/b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6/ui/views/controls/menu/menu_controller.cc
,
Nov 14
Update: Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14) using latest canary version 72.0.3610.0 and the issue is found Fixed. Hence, adding respective TE-Verified labels. Please refer the attached screen-cast. Thank You..!!
,
Nov 14
This is now fixed - the menu dismisses when you press the accelerator and the accelerator is dispatched to the browser window.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa48f013da7d20e49167ea5946fd37320ea57fc commit ffa48f013da7d20e49167ea5946fd37320ea57fc Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Nov 19 15:12:46 2018 Revert "views: close menus when accelerators are pressed on Mac" This reverts commit b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6. Reason for revert: Introduces https://crbug.com/906075 - bare command press closes menus Original change's description: > views: close menus when accelerators are pressed on Mac > > This change: > > 1) Has MenuController consider command to be an accelerator key, along with > control and alt, for the purpose of not searching for mnemonics; > 2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing > which tells the menu to close for an accelerator > > Bug: 885138 > Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a > Reviewed-on: https://chromium-review.googlesource.com/c/1334147 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607699} TBR=ellyjones@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885138 Change-Id: If98c70bcab18df7bd4895cbbc603c1878ba9ef91 Reviewed-on: https://chromium-review.googlesource.com/c/1341218 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#609294} [modify] https://crrev.com/ffa48f013da7d20e49167ea5946fd37320ea57fc/chrome/browser/ui/views/chrome_views_delegate.h [modify] https://crrev.com/ffa48f013da7d20e49167ea5946fd37320ea57fc/chrome/browser/ui/views/chrome_views_delegate_mac.cc [modify] https://crrev.com/ffa48f013da7d20e49167ea5946fd37320ea57fc/ui/views/controls/menu/menu_controller.cc
,
Nov 19
,
Nov 20
Update: Rechecked the above issue on Mac (10.13.1, 10.13.6, 10.14.2) using latest Canary version #72.0.3616.0 and the issue is still Reproducible. Please refer the attached screen-cast. Thank You..!!
,
Nov 20
#13: Yes, that's because I had to revert my fix (see #11) :(
,
Dec 11
,
Dec 24
Can you test if your other keyboard shortcuts are failing as well? (new window, close tab, etc.) Also, when your cursor is in a text field? I believe I'm seeing the same behavior on Linux 71.0.3578.80 : All browser keyboard shortcuts fail when: - the cursor is focused in the browser's Search box, the address bar, or any text field. - the menu is open as described by OP
,
Jan 19
(4 days ago)
My issue mentioned above was caused by a bug in the Gnome keyboard layouts. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Sep 18