Flaky test: TextPaintTimingDetectorTest.LastTextPaint_ReportFirstPaintTime |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rhalavati@google.com webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4) Builders failed on: - WebKit Android (Nexus4): https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29 Please see the following as an example: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F82581%2F%2B%2Frecipes%2Fsteps%2Fwebkit_unit_tests%2F0%2Flogs%2FTextPaintTimingDetectorTest.LastTextPaint_ReportFirstPaintTime%2F0
,
Sep 18
,
Sep 18
,
Sep 18
The test is flaky because EXPECT_ET is used to compare two clamped times which can be the same value.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2023b99193454d3d790e535cee140942f404fa23 commit 2023b99193454d3d790e535cee140942f404fa23 Author: Liquan(Max) Gu <maxlg@chromium.org> Date: Tue Sep 18 16:36:15 2018 [FCP++] Fix test flakiness due to time clamping The test LastTextPaint_ReportFirstPaintTime is flaky because it used EXPECT_GT for time comparison. This is an issue because time is clamped. We should use EXPECT_GE instead. Bug: 885123 Change-Id: I519eeb23dcd9a1376cf91ecdc288fbf6d7b40daa Reviewed-on: https://chromium-review.googlesource.com/1230436 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592073} [modify] https://crrev.com/2023b99193454d3d790e535cee140942f404fa23/third_party/blink/renderer/core/paint/text_paint_timing_detector_test.cc
,
Sep 18
Removing from sheriff queue.
,
Sep 18
The CL should have fixed the bug. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rhalavati@chromium.org
, Sep 18Labels: OS-Android