New issue
Advanced search Search tips

Issue 885119 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Disable Password Generation on Android by default

Project Member Reported by fhorschig@chromium.org, Sep 18

Issue description

The password generation has launched on all platforms and was enabled by default with M70.

For Android, there is no code path that would give a user access to the generation itself but the client-side metrics and other operations preparing the generation would happen anyway. To see differences in stability, it makes more sense to disable the feature per default and enable it via Finch as opposed to disabling it via Finch.

Therefore, I would like to merge https://crrev.com/c/1226605 which already landed:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c52de9dbb04923adc7d676959306e67617ca6b2b

commit	c52de9dbb04923adc7d676959306e67617ca6b2b
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Tue Sep 18 10:44:35 2018

[Android] Disable automatic password generation by default

The feature wasn't launched in M70 on Android yet and is currently
disabled via Finch.

This CL ensures that Finch only enables this which is a healthier
default as Finch isn't meant as a rollout control tool but for
experimenting.

Change-Id: I3939615186d4446dbcc99779962bfd0f66f2d42c
Reviewed-on: https://chromium-review.googlesource.com/1226605
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591992}
[modify] https://crrev.com/c52de9dbb04923adc7d676959306e67617ca6b2b/components/autofill/core/common/autofill_features.cc
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 18

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge to 70, branch 3538.
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 21

Cc: benmason@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-70
This has been merged in https://chromium-review.googlesource.com/c/chromium/src/+/1230026.

Sign in to add a comment