New issue
Advanced search Search tips

Issue 885102 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus Ring is seen chopped on 'open PDF in Preview 'option.

Reported by shruti.j...@etouch.net, Sep 18

Issue description

Chrome Version : 71.0.3554.0 (Official Build) 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} 32/64 bit
OS :Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

Steps to reproduce:
1.Launch chrome and give print command.
2.Click on 'More settings' and Press Tab key and bring focus on 'open PDF in Preview'.
3.Observe focus ring on 'open PDF in Preview'option.

Actual Result:Focus Ring is seen chopped on 'open PDF in Preview' option.
Expected Result: Focus Ring should be seen properly on 'open PDF in Preview' option.

This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information:
Good Build : 71.0.3551.0 (Revision : 590851)
Bad Build : 71.0.3552.2 (Revision : 591210)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting : https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1.Issue is also observed in latest Canary build #71.0.3555.0.
2.Issue is not seen on Windows (7, 8, 8.1 ,10), Linux 14.04 LTS

Kindly refer the attached screen-cast from drive link:https://drive.google.com/open?id=1W7O4MlAn1tpG_Q178v8PvSI72cVPH-Bg

Thank you..!
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740492f9aba228edd794d7bd9d148d0929895a54

commit 740492f9aba228edd794d7bd9d148d0929895a54
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 19 23:55:35 2018

Print Preview refresh: Fix some issues with the link container

Fixes some padding and focus issues in and around the link-container.
(1) Correct padding above and below link-container
(2) Make icon focusable rather than the entire row
(3) Restore shortcut in system dialog string
(4) Make icon not focusable when disabled
(5) Correct padding in other-options-settings

Bug:  884729 ,  885102 ,  884605 
Change-Id: I0c8e1ac700ef93a4c6e247329d66285386af9f9f
Reviewed-on: https://chromium-review.googlesource.com/1231826
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592614}
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/app/printing_strings.grdp
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/link_container.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/link_container.js
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/other_options_settings.html
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/resources/print_preview/new/other_options_settings.js
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/740492f9aba228edd794d7bd9d148d0929895a54/chrome/test/data/webui/print_preview/system_dialog_browsertest.js

Status: Fixed (was: Assigned)

Sign in to add a comment