New issue
Advanced search Search tips

Issue 885094 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Error message is not seen for spacebar entries in textfield

Reported by khushal....@etouch.net, Sep 18 
Chrome Version: 71.0.3554.0 (Official Build) Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} (32/64-bit)

OS: Windows (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux (14.04 LTS).

What steps will reproduce the problem?
(1) Launch chrome, open NTP and press 'Ctrl+P' to open preview page.
(2) Click on Text field under 'Pages' section of Print preview.
(3) Now press "Space bar" key and Observe.

Actual Result: [Print Preview] Error message is not seen for space bar entries in text field.

Expected Result: Error message should be seen for space bar entries in text field.

This is a regression issue, broken in M-71 series, below is manual regression range:
Good build: 71.0.3551.0 (Revision: 590851)
Bad build:  71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also senn on M-71 Canary #71.0.3555.0.

Kindly review the attached screen-cast for reference.

Thank you..!!
Actual Video.mov
4.5 MB View Download
Expected Video.mov
3.6 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4756a5ebdcd7ced17fe797a74da76725e11f9811

commit 4756a5ebdcd7ced17fe797a74da76725e11f9811
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Sep 22 00:42:38 2018

Print Preview Refresh: Fix some pages bugs

Splitting out fixes for bugs from change to dropdown, in case we decide
not to keep dropdown change. Addresses some focus issues, and removes
use of auto-validate. Auto-validate does not work well for this section
as some errors (e.g. out of range) cannot be caught by the auto
validation. Having 2 different sets of logic for setting the input
invalid (auto-validate + JS validation) causes some bugs.

Bug:  887231 ,  886591 ,  886542 ,  885094 ,  886560 
Change-Id: I053899718a735fa8bcc23df27d36b23d2c26e0b0
Reviewed-on: https://chromium-review.googlesource.com/1238868
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593394}
[modify] https://crrev.com/4756a5ebdcd7ced17fe797a74da76725e11f9811/chrome/browser/resources/print_preview/new/input_behavior.js
[modify] https://crrev.com/4756a5ebdcd7ced17fe797a74da76725e11f9811/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/4756a5ebdcd7ced17fe797a74da76725e11f9811/chrome/browser/resources/print_preview/new/pages_settings.js

Comment 2 by khushal....@etouch.net, Sep 24

Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Update:

Rechecked the above issue on Windows (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) and Linux (14.04 LTS) using latest Canary version #71.0.3559.0 and the issue is found FIXED.
Hence, adding respective Labels.

Kindly refer the attached screen-cast.

Thank you..!!
Fixed Video.mov
4.4 MB View Download

Comment 3 by rbpotter@chromium.org, Sep 24

Status: Verified (was: Assigned)
►

Sign in to add a comment