Search password box is not aligned properly on changing the device orientation from portrait to landscape mode and vice versa. |
||||
Issue descriptionApp Version: 70.0.3538.21 beta iOS Version: iOS 10.3.3,11.4 Device: iPhones only (iPhone 8 and below devices) Precondition: 1- Have 4 to 5 passwords saved Steps to reproduce: 1. Launch Chrome. 2. Tap on Menu > Settings > Passwords 3. Tap on Search passwords. 4. Scroll the passwords upwards. 5. Change the device orientation to landscape mode. Observed results: Search Passwords box is not aligned properly Expected results: Search Passwords box should fit the screen size as per the device orientation Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA New UI in M70 Bug reproducible on the current beta channel build : NA New UI in M70 Link to video/image: https://drive.google.com/file/d/1oIJ431jECAuL7woCp0rlU1XU2FNfI9qE/view?usp=sharing
,
Sep 18
Assigning to djean@ who implemented the feature AFAIK.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a10f2c77d836e8f4afca29a7e31418a95f13804e commit a10f2c77d836e8f4afca29a7e31418a95f13804e Author: David Jean <djean@google.com> Date: Wed Sep 19 08:24:24 2018 [ios] Added cancel button right of password search text field Added slide in-out cancel button to the password search field. Added replacing 'Enter' on OSK (On-Screen-Keyboard) by 'Search'. Added constraints which hold when rotating device. Search not focused: https://drive.google.com/file/d/1SVrSJuKEzPTaJUx4dhsNBI6WRPltLkg1/view?usp=sharing Search focused: https://drive.google.com/file/d/13jF7BBE1gP0jmKgONVSA4JSnF9oikisY/view?usp=sharing Bug: 883807, 885092 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56ebf32b57a90c6f4ddc622eb9f192a48bcd3d1e Reviewed-on: https://chromium-review.googlesource.com/1225879 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592343} [modify] https://crrev.com/a10f2c77d836e8f4afca29a7e31418a95f13804e/ios/chrome/browser/ui/settings/cells/settings_search_item.mm
,
Sep 19
,
Sep 25
Verified on 71.0.3561.0 Canary, iPhone 5S iOS 10.3.3, iPhone 6 iOS 10.3.3 Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vabr@chromium.org
, Sep 18Cc: ioanap@chromium.org
Labels: -Pri-2 Hotlist-Polish Pri-3
Status: Available (was: Untriaged)