New issue
Advanced search Search tips

Issue 885090 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Print Preview]Search icon is misplaced from 'Search destination' text field on pressing 'Tab' key.

Reported by rp...@etouch.net, Sep 18 
Chrome Version: 71.0.3554.0 (Official Build)Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10),Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview
2. Now click on 'Change' button under destination to open 'Select a destination' overlay
3. Now resize browser window from bottom to top placing cursor in 'Search destination' text field and press 'Tab' key , observe

Actual Result: Search icon is misplaced from 'Search destination' text field on pressing 'Tab' key
Expected Result: Search icon should be seen properly

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3551.0 (Revision: 590851)
Bad build : 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
Actual_video.mp4
498 KB View Download
Expected_video.mp4
606 KB View Download
Actual_Expected_screenshot.png
66.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12770d1657f8823f5e867bd3e60e8d2c05065b6

commit a12770d1657f8823f5e867bd3e60e8d2c05065b6
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Sep 21 16:07:04 2018

Print Preview Refresh: Fix destinations polish bugs

Fixing:
(1) Action links fell out of the tab order because destinations_dialog
and destinations_list were not correctly importing action_link.html
(2) Absolute positioning of icon to set it on top of the cr-input in
print_preview_search_box led to icon getting misplaced when browser
window size changed. Fix by adding a prefix in cr-input.
(3) Destination icon was shrinking for large font sizes due to using
flex layout. Make icon fixed size (20px, per spec).
(4) Ensure there is enough margin on the "Manage" link to show the
focus outline.

Bug:  884600 ,  885090 ,  886593 ,  887227 ,  887229 
Change-Id: Ic7d910ad1460e8d457186b9c189797f12db4de5f
Reviewed-on: https://chromium-review.googlesource.com/1237137
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593205}
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/a12770d1657f8823f5e867bd3e60e8d2c05065b6/ui/webui/resources/cr_elements/cr_input/cr_input.html

Comment 2 by rp...@etouch.net, Sep 24

Labels: TE-Verified-M71 TE-Verified-71.0.3559.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14) using latest Canary build : 71.0.3559.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mp4
887 KB View Download

Comment 3 by rbpotter@chromium.org, Sep 24

Status: Verified (was: Assigned)
►

Sign in to add a comment