New issue
Advanced search Search tips

Issue 885088 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 714618



Sign in to add a comment

Keyboard is not dismissed on tapping on Edit when the cursor is in Search passwords.

Project Member Reported by pmadalla@chromium.org, Sep 18

Issue description

App Version: 70.0.3538.21 beta
iOS Version: iOS 10.3.3, 11.4
Device: iPhones only

Precondition:
1- Have 4 to 5 passwords saved

Steps to reproduce:
1. Launch Chrome.
2. Tap on Menu > Settings > Passwords
3. Tap on Search passwords.
4. Scroll the passwords upwards.
5. Tap on Edit

Observed results: 
Keyboard is displayed.

Expected results: 
Keyboard should be dismissed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA    
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on the current beta channel build : NA New UI in M70
Bug reproducible on the current beta channel build : NA New UI in M70

Link to video/image: 
https://drive.google.com/file/d/1PZgJEGrHZ081lj4QZtv2kkWFbSTzKTyX/view?usp=sharing

 
Blocking: 714618
Cc: ioanap@chromium.org
Labels: -Pri-2 Hotlist-Polish Pri-3
Status: Available (was: Untriaged)
Cc-ing Ioana in case of longing for some iOS development again. :)
Cc: -ioanap@chromium.org
Owner: djean@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c48b7b74b08aace0004830d37405e9d3c5fe7fc

commit 0c48b7b74b08aace0004830d37405e9d3c5fe7fc
Author: David Jean <djean@google.com>
Date: Wed Sep 19 09:37:29 2018

[ios] Always remove keyboard on password search edit

Bug:  885088 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5d11b0b736b1b040674aef1911ca8a9510e9402c
Reviewed-on: https://chromium-review.googlesource.com/1230676
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592354}
[modify] https://crrev.com/0c48b7b74b08aace0004830d37405e9d3c5fe7fc/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in:

App Version: 71.0.3561.0 canary
iOS Versions: 10.3.3, 11.4.1, 12.0
Devices: iPhone 7, iPhone 8 Plus, iPhoneX

Keyboard is not displayed on password search edit

Video:
https://drive.google.com/open?id=1CWjGTh-pcVGec3I4U25zUvvuBzBK4gdo

Sign in to add a comment