New issue
Advanced search Search tips

Issue 885086 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 890165



Sign in to add a comment

Enable CRD remote command for ARC++ Kiosk apps.

Project Member Reported by antrim@chromium.org, Sep 18

Issue description

Current implementation allows connection to non-ARC Kiosks only.

Change implementation to allow connection to auto-started ARC++ Kiosks too.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80c9324dcbb1239ebab7d8c016a5cb7b88df5d50

commit 80c9324dcbb1239ebab7d8c016a5cb7b88df5d50
Author: Denis Kuznetsov <antrim@google.com>
Date: Tue Sep 18 19:03:32 2018

Enable CRD for ARC Kiosks

Bug:  885086 
Change-Id: I8046229bdb8ae2ab7dbd36254869320331f1f2e1
Reviewed-on: https://chromium-review.googlesource.com/1230022
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592129}
[modify] https://crrev.com/80c9324dcbb1239ebab7d8c016a5cb7b88df5d50/chrome/browser/chromeos/policy/remote_commands/crd_host_delegate.cc

Status: Fixed (was: Started)
Summary: Enable CRD remote command for ARC++ Kiosk apps. (was: Enable CRD for ARC++ Kiosk apps.)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95eae432c1a4f6c69b31e602e7df94468f8d4bf4

commit 95eae432c1a4f6c69b31e602e7df94468f8d4bf4
Author: Denis Kuznetsov <antrim@google.com>
Date: Tue Sep 18 20:00:05 2018

Followup for Enable CRD for ARC Kiosks

Bug:  885086 
Change-Id: I1eb764626437c07008a0f44d4a7b0f47b05f931a
Reviewed-on: https://chromium-review.googlesource.com/1232093
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592164}
[modify] https://crrev.com/95eae432c1a4f6c69b31e602e7df94468f8d4bf4/chrome/browser/chromeos/policy/remote_commands/crd_host_delegate.cc
[modify] https://crrev.com/95eae432c1a4f6c69b31e602e7df94468f8d4bf4/chrome/browser/chromeos/policy/remote_commands/device_command_start_crd_session_job.h

Is the code for ARC++ in? Do I need to file a new launch bug for Kiosk CRD for ARC++ apps?
Code is in (see #3). Changes are small, but I believe that we should have separate launch bug (client-side only, as server-side does not distinguish between ARC/non-ARC kiosks)

Is there a reason this is blocking the Kiosk CRD for Chrome app? They're separate right?
Blocking: -864384 890165
There was no issue for ARC++ Kiosks, so I've assigned it to existing issue. Will update now.
Status: Verified (was: Fixed)
verified on 09/20/2018 using DMS server

Sign in to add a comment