New issue
Advanced search Search tips

Issue 885039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus does not traverse in sequence in 'More settings' section, i.e. 'Tab' key skips 'Fit to page' option.

Reported by avsha...@etouch.net, Sep 18

Issue description

Chrome Version : 71.0.3554.0 (Official Build) 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} 32/64 bit
OS : Windows (7, 8, 8.1 ,10), Linux 14.04 LTS, Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

Test URL : http://unec.edu.az/application/uploads/2014/12/pdf-sample.pdf

What steps will reproduce the problem?
1. Launch chrome, navigate to above test URL and give print command.
2. Select any printer from 'Destination' list and expand 'More settings' section.
3. Press 'Tab' key twice to bring focus on 'Fit to page' checkbox and observe.

Actual Result : Focus does not traverse in sequence in 'More settings' section, i.e. 'Tab' key skips 'Fit to page' option and focus directly moves to 'Scale' text box.

Expected Result : Focus should travel in sequence for all options in 'More settings' section when using 'Tab' key.

This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information:
Good Build : 71.0.3551.0 (Revision : 590851)
Bad Build : 71.0.3552.2 (Revision : 591210)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting : https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also observed in latest Canary build #71.0.3555.0 and issue can be seen on all PDF pages.

Thank you..!
 
Actual_Result.mp4
887 KB View Download
Expected_Result.mp4
951 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6113ed7a9644d287e512d78a17a08be0c7e2818

commit e6113ed7a9644d287e512d78a17a08be0c7e2818
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 00:33:35 2018

Print Preview Refresh: Fix error handling

(1) Make errors expand/contract rather than pre-allocating space
(2) Adjust padding so that padding is always 16px regardless of error
state
(3) Fix an issue with pages error not appearing when radio button is
reselected
(4) Make error line-height correct.
(5) Other changes to ensure labels stay correctly aligned with
controls regardless of control height.
(6) No hand pointer on error text.

Bug:  884752 ,  884729 ,  884603 ,  884640 ,  885039 
Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef
Reviewed-on: https://chromium-review.googlesource.com/1229618
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592629}
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/browser/resources/print_preview/new/scaling_settings.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/pages_settings_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/settings_section_test.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/chrome/test/data/webui/print_preview/system_dialog_browsertest.js
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_browser_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/e6113ed7a9644d287e512d78a17a08be0c7e2818/ui/webui/resources/cr_elements/shared_vars_css.html

Status: Fixed (was: Assigned)

Sign in to add a comment