New issue
Advanced search Search tips

Issue 885026 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 21
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Movement of copies text field is seen after clicking on spinner.

Reported by pranjali...@etouch.net, Sep 18 
Chrome version :71.0.3554.0 (Official Build) Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} (32/64-Bit)

OS:  Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14)  and Linux(14.04 LTS) OS

What steps will reproduce the problem?
1.Launch chrome and open NTP.
2.Give print command and click on spinner i.e increase number of copies.
3.Observe

Actual  : Movement of copies text field is seen after clicking on spinner.
Expected: Movement of copies text field should not be seen after clicking on spinner.

This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information:
Good Build: 71.0.3551.0 (Revision: 590851)
Bad Build : 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
Actual Result.mp4
402 KB View Download
Expected Result.mp4
493 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63451843bf9fb084a878417e4d118caa72a2f003

commit 63451843bf9fb084a878417e4d118caa72a2f003
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Sep 20 22:54:45 2018

Print Preview refresh: Fix radio and checkbox ripple sizing issues

Default ripple size of 40px is 2px larger than the desired height for
a print preview settings section/row of settings section. Reduce
ripple size to match this limitation.

For copies' collate box, remove unnecessary margin that caused the
number input to shift when the checkbox appeared. Also reduce the
default size for number inputs, since neither should exceed 3 digits,
and ensure the inline margin is always large enough for the ripple
regardless of font size.

Bug:  885013 ,  885026 ,  886551 
Change-Id: I29b8316b9f49e24ffcb020085ef9bc3cdb6e0ec9
Reviewed-on: https://chromium-review.googlesource.com/1235204
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592985}
[modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/copies_settings.html
[modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/print_preview_shared_css.html

Comment 2 by pranjali...@etouch.net, Sep 21

Labels: TE-Verified-M71 TE-Verified-71.0.3558.0
Update:

Rechecked the above issue using latest canary build#71.0.3558.0 on  Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14)  and Linux(14.04 LTS) OS and issue s fixed.

Please refer attached screen cast.

Thank You...
Canary Behaviour.mp4
384 KB View Download

Comment 3 by rbpotter@chromium.org, Sep 21

Status: Verified (was: Assigned)
►

Sign in to add a comment