Regression: Blue focus ring of collate checkbox overlaps on copies text field
Reported by
pranjali...@etouch.net,
Sep 18
|
||||
Issue descriptionChrome version :71.0.3554.0 (Official Build) Revision 50b24262ba0c4e14c723112f9aad3686dc6462c1-refs/branch-heads/3554@{#1} (32/64-Bit) OS: Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) OS What steps will reproduce the problem? 1.Launch chrome and open NTP. 2.Give print command and enter number of copies such that collate option appears. 3.Press tab key and observe. Actual : Blue focus ring overlaps on copies text field Expected: Blue focus ring should not overlap on copies text field This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information: Good Build: 71.0.3551.0 (Revision: 590851) Bad Build : 71.0.3552.2 (Revision: 591210) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/affcf0c8f45e22c2aed34257714da66182c0d015..a67666adf1d4f52f814c59f22bef20096fb565ee Suspect: r591109 ?? @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Tried to perform 'per-revision' bisect but it shows "We don't have enough builds to bisect" error message (tried on different machines but still got the same error). 2. Hence providing suspect through 'Chromium bisect'. Kindly refer the attached screen-cast. Thank You..!!
,
Sep 20
With respect to comment#1, 1.Rechecked the above issue using canary build#71.0.3556.0 and 71.0.3557.0 on Linux(14.04) and win-10 and issue is fixed. 2.Also checked on reported build i.e 71.0.3552.2 / 71.0.3554.0 and issue is able to reproducible. Please find below attached screen cast. Thank You..
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63451843bf9fb084a878417e4d118caa72a2f003 commit 63451843bf9fb084a878417e4d118caa72a2f003 Author: rbpotter <rbpotter@chromium.org> Date: Thu Sep 20 22:54:45 2018 Print Preview refresh: Fix radio and checkbox ripple sizing issues Default ripple size of 40px is 2px larger than the desired height for a print preview settings section/row of settings section. Reduce ripple size to match this limitation. For copies' collate box, remove unnecessary margin that caused the number input to shift when the checkbox appeared. Also reduce the default size for number inputs, since neither should exceed 3 digits, and ensure the inline margin is always large enough for the ripple regardless of font size. Bug: 885013 , 885026 , 886551 Change-Id: I29b8316b9f49e24ffcb020085ef9bc3cdb6e0ec9 Reviewed-on: https://chromium-review.googlesource.com/1235204 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592985} [modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/copies_settings.html [modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/number_settings_section.html [modify] https://crrev.com/63451843bf9fb084a878417e4d118caa72a2f003/chrome/browser/resources/print_preview/new/print_preview_shared_css.html
,
Sep 21
Update: Rechecked the above issue using latest canary build#71.0.3558.0 on Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) OS and issue s fixed. Please refer attached screen cast. Thank You...
,
Sep 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rbpotter@chromium.org
, Sep 19