New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 885011 link

Starred by 1 user
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Sep 28
Cc:
harrisjay@google.com
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Extension icons in PWA title bar shifts other title bar elements

Project Member Reported by alancutter@chromium.org, Sep 18 
Chrome Version: 70
OS: Windows 7, Linux

What steps will reproduce the problem?
(1) Install Quick Tabs: https://chrome.google.com/webstore/detail/quick-tabs/jnjfeinjfmenlddahdjdmgpbokiacbbb
(2) Visit soft-puppy.glitch.me and wait for it to load.
(3) App menu > Install Soft Puppy.
(4) App menu > Quick Tabs icon

What is the expected result?

Items in the titlebar shouldn't move around, the Quick Tabs icon should appear.

What happens instead?

The Quick Tabs icon is clipped, other titlebar elements are shifted downwards.
titlebar-shifted.png
18.5 KB View Download

Comment 1 by alancutter@chromium.org, Sep 18 

This affects Windows 10 as well.
titlebar-shifted-windows10.png
12.4 KB View Download

Comment 2 by alancutter@chromium.org, Sep 18 

This works fine in Chrome OS.
titlebar-not-shifted-chromeos.png
14.5 KB View Download

Comment 3 by alancutter@chromium.org, Sep 18

Cc: harrisjay@google.com

Comment 4 by alancutter@chromium.org, Sep 25 

Before and after screenshots for Linux/Windows 7 of WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1242584
before.png
57.8 KB View Download
after.png
57.7 KB View Download

Comment 5 by alancutter@chromium.org, Sep 27 

Minor changes were made to browser action icon layout for this CL, adding screenshots to show existing layout in the main browser hasn't been affected.
browser-action-icons-before.png
92.2 KB View Download
browser-action-icons-after.png
92.2 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43526ef32411ad97ba0eb2dd16237e2f7090bfcb

commit 43526ef32411ad97ba0eb2dd16237e2f7090bfcb
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Sep 27 11:04:26 2018

[Linux & Windows] Fix overly dynamic hosted app title bar height

In hosted app windows extension browser action icons may exceed the vertical
size of the menu button causing the title bar to increase in size when shown.

This CL fixes the title bar height to ignore hosted app buttons other than
the menu button to ensure title bar height consistency.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359771&signed_aid=KtAw0K1pvNkili8_InVRHg==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359772&signed_aid=BomSSrucsiT4t0Ixn8hGdw==&inline=1

Bug:  885011 

Change-Id: Iedcc6eeaaff649d106e5cd1e1c7be1cfe13047ef
Reviewed-on: https://chromium-review.googlesource.com/1242584
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594662}
[modify] https://crrev.com/43526ef32411ad97ba0eb2dd16237e2f7090bfcb/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/43526ef32411ad97ba0eb2dd16237e2f7090bfcb/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/43526ef32411ad97ba0eb2dd16237e2f7090bfcb/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/43526ef32411ad97ba0eb2dd16237e2f7090bfcb/chrome/browser/ui/views/frame/opaque_browser_frame_view_browsertest.cc
[modify] https://crrev.com/43526ef32411ad97ba0eb2dd16237e2f7090bfcb/chrome/browser/ui/views/toolbar/browser_actions_container.cc

Comment 7 by alancutter@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment