New issue
Advanced search Search tips

Issue 884999 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

rendering benchmark failing on webview bots

Project Member Reported by sadrul@chromium.org, Sep 18

Issue description

Sample link: https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus6%20WebView%20Perf/2657

Error in the logs:

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/b/swarming/w/ir/.swarming_module/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/b/swarming/w/ir/.swarming_module/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/perf/surface_stats_collector.py", line 74, in _CollectorThread
    raise Exception('Unable to get surface flinger latency data')
Exception: Unable to get surface flinger latency data
...
...
...
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 126, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 302, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/tools/perf/measurements/rendering.py", line 62, in ValidateAndMeasurePage
    trace_result = tab.browser.platform.tracing_controller.StopTracing()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/core/tracing_controller.py", line 53, in StopTracing
    return self._tracing_controller_backend.StopTracing()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 157, in StopTracing
    '\n'.join(raised_exception_messages))
TracingException: Exceptions raised when trying to stop tracing:
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 145, in StopTracing
    agent.CollectAgentTraceData(builder)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent.py", line 30, in CollectAgentTraceData
    surface_flinger_trace_data = self._platform_backend.StopDisplayTracing()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/android_platform_backend.py", line 190, in StopDisplayTracing
    refresh_period, timestamps = self._surface_stats_collector.Stop()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/perf/surface_stats_collector.py", line 47, in Stop
    (refresh_period, timestamps) = self._GetDataFromThread()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/perf/surface_stats_collector.py", line 95, in _GetDataFromThread
    raise ret
Exception: Unable to get surface flinger latency data

Looks like there may still be some issues in surface_stats_collector.py. This seems related to  issue 881873 .
 
 Issue 885258  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/582a06eb78355d29316b9d4a2d3181e725194e52

commit 582a06eb78355d29316b9d4a2d3181e725194e52
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Wed Sep 19 19:18:20 2018

Telemetry: don't fail when SF cannot find win name

urfaceStatsCollector cannot find the SurfaceView window
name in webview and fails due to a recent CL:
https://chromium-review.googlesource.com/c/catapult/+/1216504

Here, we make SurfaceStatsCollector return just the refresh
period without presentation timestamps instead of failing,
which is identical to the behaviour before the above-mentioned
CL.

TBR=perezju@chromium.org

Bug:  chromium:884999 
Change-Id: Id9109d40b19f8a8ac7c7184f2f758db09d95a326
Reviewed-on: https://chromium-review.googlesource.com/1233939
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>

[modify] https://crrev.com/582a06eb78355d29316b9d4a2d3181e725194e52/tracing/tracing/metrics/rendering/frame_time.html
[modify] https://crrev.com/582a06eb78355d29316b9d4a2d3181e725194e52/devil/devil/android/perf/surface_stats_collector.py
[modify] https://crrev.com/582a06eb78355d29316b9d4a2d3181e725194e52/telemetry/telemetry/web_perf/metrics/rendering_stats.py
[modify] https://crrev.com/582a06eb78355d29316b9d4a2d3181e725194e52/telemetry/telemetry/web_perf/metrics/rendering_stats_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70b00be276bf695d4e4f72a075eb3d9454eaedd1

commit 70b00be276bf695d4e4f72a075eb3d9454eaedd1
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Sep 19 20:23:49 2018

Roll src/third_party/catapult 92ef0386b8b6..582a06eb7835 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/92ef0386b8b6..582a06eb7835


git log 92ef0386b8b6..582a06eb7835 --date=short --no-merges --format='%ad %ae %s'
2018-09-19 chiniforooshan@chromium.org Telemetry: don't fail when SF cannot find win name


Created with:
  gclient setdep -r src/third_party/catapult@582a06eb7835

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:884999 
TBR=sullivan@chromium.org

Change-Id: I7ce1f90275c2422e5cb7a0325379004f8e30cc3d
Reviewed-on: https://chromium-review.googlesource.com/1234957
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592533}
[modify] https://crrev.com/70b00be276bf695d4e4f72a075eb3d9454eaedd1/DEPS

Status: Fixed (was: Started)
This error is fixed. I can see data in the perf dashboard.

However, the webview bot is still failing on some stories due to a native crash. It looks like the new set of errors was introduced in https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus6%20WebView%20Perf/2659

I will close this bug. The other issue is tracked in crbug.com/887152.

Sign in to add a comment